Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.22] Update Dockerfile to use JDK 17 #878

Merged
merged 2 commits into from
Dec 19, 2024
Merged

[1.22] Update Dockerfile to use JDK 17 #878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22a0cee
Update Dockerfile
cmizzi Aug 8, 2024
066080a
Update README.md
cmizzi Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,14 @@ FROM node:18-bullseye

RUN npm install -g svg2img @bubblewrap/cli

RUN apt update && apt install -y openjdk-11-jre openjdk-11-jdk lib32stdc++6 lib32z1
RUN set -xe \
&& apt update \
&& apt install -y openjdk-17-jre openjdk-17-jdk lib32stdc++6 lib32z1 \
&& rm -rf /var/lib/apt/lists/*

RUN mkdir -p /root/.bubblewrap && \
echo '{ "jdkPath": "/usr/lib/jvm/java-11-openjdk-amd64", "androidSdkPath": "" }' > /root/.bubblewrap/config.json
RUN set -xe \
&& mkdir -p /root/.bubblewrap \
&& echo '{ "jdkPath": "/usr/lib/jvm/java-17-openjdk-amd64", "androidSdkPath": "" }' > /root/.bubblewrap/config.json

RUN yes | bubblewrap doctor

Expand Down
2 changes: 1 addition & 1 deletion packages/cli/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ Information on the signature fingerprints for the application. Use to generate t

## Manually setting up the Environment

### Get the Java Development Kit (JDK) 11.
### Get the Java Development Kit (JDK) 17.
The Android Command line tools requires the correct version of the JDK to run. To prevent version
conflicts with a JDK version that is already installed, Bubblewrap uses a JDK that can unzipped in
a separate folder.
Expand Down