feat: implement storage.getCookies and storage.setCookie
#1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Nov 24, 2023
OrKoN
reviewed
Nov 24, 2023
OrKoN
reviewed
Nov 24, 2023
OrKoN
reviewed
Nov 24, 2023
sadym-chromium
added a commit
that referenced
this pull request
Nov 24, 2023
Sometimes it is required to have types from not-yet merged branch of spec (#1593). This PR provides a way to specify a branch of a specific commit to update types from. --------- Co-authored-by: Maksim Sadym <sadym@google.com>
sadym-chromium
force-pushed
the
sadym/cookies
branch
from
393bbb4 to
cd1e930
Compare
sadym-chromium
changed the title
storage.getCookiesstorage.getCookies
sadym-chromium
force-pushed
the
sadym/cookies
branch
6 times, most recently
from
55421d3 to
5c5cc68
Compare
sadym-chromium
force-pushed
the
sadym/cookies
branch
2 times, most recently
from
d5df1bf to
e6cf54d
Compare
sadym-chromium
force-pushed
the
sadym/cookies
branch
from
e6cf54d to
b8d270e
Compare
sadym-chromium
changed the title
storage.getCookiesstorage.cookies
sadym-chromium
force-pushed
the
sadym/cookies
branch
from
d046dee to
a9670f0
Compare
added 18 commits
January 11, 2024 21:54
This reverts commit 55f5204.
sadym-chromium
force-pushed
the
sadym/cookies
branch
from
bafdc82 to
fdd6cb6
Compare
jrandolf-2
reviewed
Jan 12, 2024
|
lgtm! |
jrandolf-2
approved these changes
Jan 12, 2024
| @@ -0,0 +1,283 @@ | |||
| /* | |||
| * Copyright 2023 Google LLC. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright 2023 Google LLC. | |
| * Copyright 2024 Google LLC. |
| "params": { | ||
| "expression": f"document.body.innerHTML = '{html_content}'", | ||
| "functionDeclaration": "(html_content) => { document.body.innerHTML = html_content }", |
There was a problem hiding this comment.
Nit: Let's consider using the script from Puppeteer I think it may be less falky.
As the DOM should be stable all written by the time the command returns.
document.open();
document.write(html);
document.close();| const browsingContextId: string = descriptor.context; | ||
| const browsingContext = | ||
| this.#browsingContextStorage.getContext(browsingContextId); | ||
| const url = NetworkProcessor.parseUrlString(browsingContext?.url ?? ''); |
There was a problem hiding this comment.
Nit: This should not live on the NetworkProcessor but extracted into helper.
sadym-chromium
pushed a commit
that referenced
this pull request
Jan 18, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.4](chromium-bidi-v0.5.3...chromium-bidi-v0.5.4) (2024-01-17) ### Features * implement `Input.setFiles` ([#1705](#1705)) ([50d1921](50d1921)) * implement `storage.getCookies` and `storage.setCookie` ([#1593](#1593)) ([2b08660](2b08660)) * implement permissions ([#1645](#1645)) ([29c7b0b](29c7b0b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement storage commands:
storage.getCookiesstorage.setCookie