feat: webExtension module #3012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Jan 21, 2025
OrKoN
reviewed
Jan 21, 2025
OrKoN
reviewed
Jan 21, 2025
OrKoN
reviewed
Jan 21, 2025
OrKoN
reviewed
Jan 21, 2025
|
@LiviuArln I have pushed an update to enable CDP-fix and verified that the test returns a good CDP error. Could you please add other tests and implement error handling? Currently, only the non-chromedriver test configuration works ( @sadym-chromium I think ChromeDriver is doing exposeDevToolsProtocol elsewhere when it loads mapper. Would you mind updating it? let's chat about it tomorrow. |
OrKoN
force-pushed
the
extensions
branch
2 times, most recently
from
3574a9d to
d57019f
Compare
browser-automation-bot
added a commit
to browser-automation-bot/chromium-bidi
that referenced
this pull request
Feb 27, 2025
OrKoN
pushed a commit
that referenced
this pull request
Feb 27, 2025
Update the expectations for PR #3012. Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
OrKoN
approved these changes
Feb 27, 2025
Update the expectations for PR #3012. Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
sadym-chromium
pushed a commit
that referenced
this pull request
Feb 28, 2025
🤖 I have created a release *beep* *boop* --- ## [2.1.0](chromium-bidi-v2.0.0...chromium-bidi-v2.1.0) (2025-02-28) ### Features * webExtension module ([#3012](#3012)) ([3994b79](3994b79)) ### Bug Fixes * hide cdp.send after the mapper receives it ([#3137](#3137)) ([9ad3d11](9ad3d11)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2849