-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically derive manifests from app pages #323
Comments
Agreed. We were looking into implementing this by looking for the manifest link on the page, but it seems it can also be added using Javascript. #190 was tracking this, but I didn't realize we had closed it. |
We have support to submit by start_url, however we are using the manifest URL and not the tuple as unique identifier. We'll change it. |
This might be an unanticipated side effect of an over-enthusiastic build process, but nevertheless, "versioning" the manifest URL and serving it with an infinite expiry doesn't seem like an outrageous thing to want to do. |
Weather.com should not version these URLs (same for their serviceworker).
This is a bug with their site, not with how we identify apps.
…On Mon, Jun 19, 2017 at 6:12 AM, Michael Stillwell ***@***.*** > wrote:
[manifest_url, start_url] doesn't uniquely identify a PWA if a site
versions its manifest. This is done by e.g. https://weather.com/weather/to
day/l/12345 which currently has a manifest of
https://weather.com/weather/assets/manifest.507fcb498f4e29ac
feed7596fe002857.json.
This might be an unanticipated side effect of an over-enthusiastic build
process, but nevertheless, "versioning" the manifest URL and serving it
with an infinite expiry doesn't seem like an outrageous thing to want to do.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAF8M81nEOI1M1mFa0rzGizcFJipfqe6ks5sFnOtgaJpZM4LdSFa>
.
|
See also: w3c/manifest#586 |
The current submission form asks for a PWA Manifest URL (e.g.
https://airhorner.com/manifest.json
, nothttps://airhorner.com/
). It seems as though it'd be much more user-friendly to be able to submit any URL from the PWA which points at the Manifest. The tuple of (discovered) manifest location and thestart_url
from the manifest should be enough to uniquely identify the app.The text was updated successfully, but these errors were encountered: