Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically derive manifests from app pages #323

Closed
slightlyoff opened this issue Jan 7, 2017 · 5 comments
Closed

Automatically derive manifests from app pages #323

slightlyoff opened this issue Jan 7, 2017 · 5 comments

Comments

@slightlyoff
Copy link

The current submission form asks for a PWA Manifest URL (e.g. https://airhorner.com/manifest.json, not https://airhorner.com/). It seems as though it'd be much more user-friendly to be able to submit any URL from the PWA which points at the Manifest. The tuple of (discovered) manifest location and the start_url from the manifest should be enough to uniquely identify the app.

@andreban
Copy link
Member

andreban commented Jan 9, 2017

Agreed. We were looking into implementing this by looking for the manifest link on the page, but it seems it can also be added using Javascript. #190 was tracking this, but I didn't realize we had closed it.

@juliantoledo
Copy link
Collaborator

We have support to submit by start_url, however we are using the manifest URL and not the tuple as unique identifier. We'll change it.

@ithinkihaveacat
Copy link
Collaborator

[manifest_url, start_url] doesn't uniquely identify a PWA if a site versions its manifest. This is done by e.g. https://weather.com/weather/today/l/12345 which currently has a manifest of https://weather.com/weather/assets/manifest.507fcb498f4e29acfeed7596fe002857.json.

This might be an unanticipated side effect of an over-enthusiastic build process, but nevertheless, "versioning" the manifest URL and serving it with an infinite expiry doesn't seem like an outrageous thing to want to do.

@slightlyoff
Copy link
Author

slightlyoff commented Jun 19, 2017 via email

@adewale
Copy link

adewale commented Jun 22, 2017

See also: w3c/manifest#586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@adewale @ithinkihaveacat @slightlyoff @andreban @juliantoledo and others