-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Three listings for Accessible UK Train Timetables, traintimes.org.uk #505
Comments
This is due to traintimes using different manifest URL and start_urls for each URL on their site, which makes it tricky to uniquely identify a PWA (see #493, w3c/manifest#586 and w3c/manifest#668) This could be something a website does intentionally, but looks like a bug in this case. We should keep the older record (the first one) and delete 5630437284642816 and 5678982740049920) /cc @juliantoledo |
It's not a bug, they let you have a custom pwa per train route.
I use it this way.
…On Fri, Jul 13, 2018, 09:23 André Cipriani Bandarra < ***@***.***> wrote:
This is due to traintimes using different manifest URL and start_urls for
each URL on their site, which makes it tricky to uniquely identify a PWA
(see #493 <#493>,
w3c/manifest#586 <w3c/manifest#586> and
w3c/manifest#668 <w3c/manifest#668>)
This could be something a website does intentionally, but looks like a bug
in this case. We keep the older record (the first one) and delete
5630437284642816 and 5678982740049920)
/cc @juliantoledo <https://github.com/juliantoledo>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#505 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACxxmvoUhPvJo4xcYB8c13Ym4L9TKuOks5uGFjmgaJpZM4VNYsW>
.
|
I'll be pushing a lot of developers to think about these bespoke pwas a lot
so id suggest a better solution that deleting them :)
…On Fri, Jul 13, 2018, 09:49 Paul Kinlan ***@***.***> wrote:
It's not a bug, they let you have a custom pwa per train route.
I use it this way.
On Fri, Jul 13, 2018, 09:23 André Cipriani Bandarra <
***@***.***> wrote:
> This is due to traintimes using different manifest URL and start_urls for
> each URL on their site, which makes it tricky to uniquely identify a PWA
> (see #493 <#493>,
> w3c/manifest#586 <w3c/manifest#586> and
> w3c/manifest#668 <w3c/manifest#668>)
>
> This could be something a website does intentionally, but looks like a
> bug in this case. We keep the older record (the first one) and delete
> 5630437284642816 and 5678982740049920)
>
> /cc @juliantoledo <https://github.com/juliantoledo>
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#505 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AACxxmvoUhPvJo4xcYB8c13Ym4L9TKuOks5uGFjmgaJpZM4VNYsW>
> .
>
|
I considered that might be intentional, but since they actually have a PWA per route / day / departure time, I thought not. For instance, https://traintimes.org.uk/Runcorn/Euston/09:04a/today has a different manifest and start_url than https://traintimes.org.uk/Runcorn/Euston/15:15/today, which is also different from https://traintimes.org.uk/Runcorn/Euston/09:04a/2018-07-13 We could group those apps by origin, but then 2 completely different PWAs under the same domain would count as a single app. |
That sounds like it's potentially more of a niche case than two related apps under the same domain, no? |
Ideally, we should group them under a single entry, but it would be a bit difficult to compare them to know they are the "same" PWA with multiple entries. |
I suggest a single listing with reference to:
The text was updated successfully, but these errors were encountered: