Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quickjs): fix can't install quickjs on Windows #143

Merged

Conversation

gfgafn
Copy link
Contributor

@gfgafn gfgafn commented Dec 28, 2023

Copy link

google-cla bot commented Dec 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gfgafn
Copy link
Contributor Author

gfgafn commented Jan 2, 2024

@mathiasbynens request review

shared/engine.js Outdated Show resolved Hide resolved
@mathiasbynens mathiasbynens merged commit 681bf45 into GoogleChromeLabs:main Jan 9, 2024
3 checks passed
mathiasbynens added a commit that referenced this pull request Jan 9, 2024
@mathiasbynens
Copy link
Member

Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants