Skip to content
This repository has been archived by the owner on Jan 21, 2021. It is now read-only.

support include: 'initial' #51

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Conversation

yyx990803
Copy link
Contributor

@yyx990803 yyx990803 commented Jan 9, 2018

This allows us to use the following setup:

plugins: [
  new HTMLWebpackPlugin(),
  new PreloadPlugin({
    // rel: 'preload'
    include: 'initial'
  }),
  new PreloadPlugin({
    rel: 'prefetch'
    // include: 'asyncChunks'
  })
]

@jeffposnick
Copy link
Contributor

Thanks, @yyx990803!

I brought up something similar at #40, but the approach there is effectively a breaking change, compared to the incremental change in this PR.

I'd be open to merging this and tagging it v2.2.0, and then potentially going with an approach described in #40 for 3.0.0.

CC: @addyosmani to give him a chance to comment about that plan if he'd like. Otherwise, I'll merge.

@jeffposnick jeffposnick merged commit 951ff9c into GoogleChromeLabs:master Jan 11, 2018
@jeffposnick
Copy link
Contributor

I've published this as 2.2.0 on npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants