fix: update comparators to handle undefined value for booleans (#549)

GoogleChromeLabs · Mar 13, 2024 · 22f2015 · 22f2015
1 parent ec5e70c
commit 22f2015
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/cli-dashboard/src/hooks/useCookieListing.tsx/index.tsx b/packages/cli-dashboard/src/hooks/useCookieListing.tsx/index.tsx
@@ -27,6 +27,10 @@ import {
   calculateEffectiveExpiryDate,
   type CookieTableData,
 } from '@ps-analysis-tool/common';
+
+/**
+ * Internal dependencies
+ */
 import calculateDynamicFilterValues from './utils/calculateDynamicFilterValues';
 import calculateBlockedReasonsFilterValues from './utils/calculateBlockedReasonsFilterValues';
 
@@ -154,7 +158,7 @@ const useCookieListing = (
         },
         useGenericPersistenceKey: true,
         comparator: (value: InfoType, filterValue: string) => {
-          const val = value as boolean;
+          const val = Boolean(value);
           return val === (filterValue === 'First Party');
         },
       },
@@ -174,7 +178,7 @@ const useCookieListing = (
         },
         useGenericPersistenceKey: true,
         comparator: (value: InfoType, filterValue: string) => {
-          const val = value as boolean;
+          const val = Boolean(value);
           return val === (filterValue === 'True');
         },
       },
@@ -211,7 +215,7 @@ const useCookieListing = (
         },
         useGenericPersistenceKey: true,
         comparator: (value: InfoType, filterValue: string) => {
-          const val = value as boolean;
+          const val = Boolean(value);
           return val === (filterValue === 'True');
         },
       },

diff --git a/.../extension/src/view/devtools/components/cookies/cookiesListing/useCookieListing/index.tsx b/.../extension/src/view/devtools/components/cookies/cookiesListing/useCookieListing/index.tsx
@@ -250,7 +250,7 @@ const useCookieListing = (domainsInAllowList: Set<string>) => {
         },
         useGenericPersistenceKey: true,
         comparator: (value: InfoType, filterValue: string) => {
-          const val = value as boolean;
+          const val = Boolean(value);
           return val === (filterValue === 'First Party');
         },
       },
@@ -270,7 +270,7 @@ const useCookieListing = (domainsInAllowList: Set<string>) => {
         },
         useGenericPersistenceKey: true,
         comparator: (value: InfoType, filterValue: string) => {
-          const val = value as boolean;
+          const val = Boolean(value);
           return val === (filterValue === 'True');
         },
       },
@@ -307,7 +307,7 @@ const useCookieListing = (domainsInAllowList: Set<string>) => {
         },
         useGenericPersistenceKey: true,
         comparator: (value: InfoType, filterValue: string) => {
-          const val = value as boolean;
+          const val = Boolean(value);
           return val === (filterValue === 'True');
         },
       },