Merge pull request #105 from GoogleChromeLabs/remove-ibc-compliant

Remove "IBC Compliant" status column
GoogleChromeLabs · Aug 16, 2023 · 97dd916 · 97dd916
2 parents b94ef24 + 6d06139
commit 97dd916
Show file tree

Hide file tree

Showing 10 changed files with 0 additions and 179 deletions.
diff --git a/packages/extension/src/utils/checkIbcCompliance.ts b/packages/extension/src/utils/checkIbcCompliance.ts
diff --git a/packages/extension/src/utils/test-data/cookieMockData.ts b/packages/extension/src/utils/test-data/cookieMockData.ts
@@ -83,7 +83,6 @@ const data: {
       url: 'https://edition.cnn.com/whatever/api',
       headerType: 'response',
       isFirstParty: true,
-      isIbcCompliant: true,
       isCookieSet: true,
       frameIdList: [1],
     },
@@ -93,7 +92,6 @@ const data: {
       url: 'https://api.pubmatic.com/whatever/api',
       headerType: 'response',
       isFirstParty: false,
-      isIbcCompliant: true,
       isCookieSet: true,
       frameIdList: [1],
     },
@@ -114,7 +112,6 @@ const data: {
       url: 'https://edition.cnn.com/whatever/api',
       headerType: 'response',
       isFirstParty: true,
-      isIbcCompliant: true,
       isCookieSet: true,
       frameIdList: [1],
     },
@@ -135,7 +132,6 @@ const data: {
       url: 'https://api.pubmatic.com/whatever/api',
       headerType: 'response',
       isFirstParty: false,
-      isIbcCompliant: true,
       isCookieSet: true,
       frameIdList: [1],
     },
@@ -156,7 +152,6 @@ const data: {
       url: 'https://api.pubmatic.com/whatever/api',
       headerType: 'response',
       isFirstParty: false,
-      isIbcCompliant: true,
       isCookieSet: true,
       frameIdList: [1],
     },

diff --git a/packages/extension/src/utils/tests/checkIbcCompliance.ts b/packages/extension/src/utils/tests/checkIbcCompliance.ts
diff --git a/packages/extension/src/view/devtools/components/sidebar/tests/index.tsx b/packages/extension/src/view/devtools/components/sidebar/tests/index.tsx
@@ -77,7 +77,6 @@ const mockResponse: {
       headerType: 'response',
       frameIdList: [1],
       isFirstParty: true,
-      isIbcCompliant: true,
       isCookieSet: true,
     },
     [uncategorized3pCookie.name]: {
@@ -87,7 +86,6 @@ const mockResponse: {
       headerType: 'response',
       frameIdList: [1],
       isFirstParty: false,
-      isIbcCompliant: true,
       isCookieSet: true,
     },
     [known1pCookie.name]: {
@@ -108,7 +106,6 @@ const mockResponse: {
       headerType: 'response',
       frameIdList: [1],
       isFirstParty: true,
-      isIbcCompliant: true,
       isCookieSet: true,
     },
     [known3pCookie.name]: {
@@ -129,7 +126,6 @@ const mockResponse: {
       headerType: 'response',
       frameIdList: [1],
       isFirstParty: false,
-      isIbcCompliant: true,
       isCookieSet: true,
     },
   },

diff --git a/...sion/src/view/devtools/components/tabContent/cookies/cookiesListing/cookieTable/index.tsx b/...sion/src/view/devtools/components/tabContent/cookies/cookiesListing/cookieTable/index.tsx
@@ -137,19 +137,6 @@ const tableColumns: ColumnDef<CookieTableData>[] = [
       </a>
     ),
   },
-  {
-    header: 'IBC Compliant',
-    accessorKey: 'isIbcCompliant',
-    cell: (info) => (
-      <p className="flex justify-center items-center">
-        {info.getValue() ? (
-          <Check className="scale-125 stroke-onyx dark:stroke-bright-gray" />
-        ) : (
-          ''
-        )}
-      </p>
-    ),
-  },
   {
     header: 'Cookie Accepted',
     accessorKey: 'isCookieSet',

diff --git a/...iew/devtools/components/tabContent/cookies/cookiesListing/cookieTable/stories/tempData.ts b/...iew/devtools/components/tabContent/cookies/cookiesListing/cookieTable/stories/tempData.ts
@@ -51,7 +51,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -77,7 +76,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -103,7 +101,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -129,7 +126,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -155,7 +151,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -181,7 +176,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -207,7 +201,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -233,7 +226,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -259,7 +251,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -285,7 +276,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -311,7 +301,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -337,7 +326,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -363,7 +351,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -389,7 +376,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -415,7 +401,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -441,7 +426,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -467,7 +451,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -493,7 +476,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -519,7 +501,6 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
   {
     parsedCookie: {
@@ -545,6 +526,5 @@ export const TempCookieData: CookieTableData[] = [
     frameIdList: [],
     isCookieSet: false,
     isFirstParty: true,
-    isIbcCompliant: false,
   },
 ];
diff --git a/packages/extension/src/view/devtools/cookies.types.ts b/packages/extension/src/view/devtools/cookies.types.ts
@@ -19,7 +19,6 @@
 import type { CookieData } from '../../localStore';
 
 export type CookieTableData = CookieData & {
-  isIbcCompliant: boolean | null;
   isCookieSet: boolean | null;
 };