Skip to content

Commit

Permalink
Merge pull request #230 from GoogleChromeLabs/fix/cli-description
Browse files Browse the repository at this point in the history
Fix : Add missing description in analytics
  • Loading branch information
mohdsayed authored Nov 4, 2023
2 parents 44ff812 + 5da10c6 commit ac0df83
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/cli/src/procedures/analyzeCookieUrls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export const analyzeCookiesUrls = async (
frameCookies[key].platform = analytics?.platform || 'Unknown';
frameCookies[key].category = analytics?.category || 'Uncategorized';
frameCookies[key].GDPR = analytics?.gdprUrl || '';
frameCookies[key].description = analytics?.description;

// some cookies may have their expires value in epoch. Convert them to string
const expires = frameCookies[key].expires;
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/utils/browserManagement/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export type Cookie = {
secure: boolean;
isBlocked?: boolean;
platform?: string;
description?: string;
category?: string;
GDPR?: string;
isFirstParty?: boolean;
Expand Down

0 comments on commit ac0df83

Please sign in to comment.