Skip to content

Commit

Permalink
fix: Highlighting logic and cookie details text
Browse files Browse the repository at this point in the history
  • Loading branch information
ayushnirwal committed Mar 13, 2024
1 parent 20cc714 commit df69bd5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ const Details = ({ selectedCookie, isUsingCDP }: DetailsProps) => {
<div className="flex gap-1 items-center mb-4">
<QuestionMark className="scale-150 mr-1" />
<p className="text-outer-space-crayola dark:text-bright-gray">
We detected that the cookie was blocked however we could not
detect the reason.
Please take a look at the network tab to get this cookie&apos;s
blocking information.
</p>
<br />
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*/
import React from 'react';
import classNames from 'classnames';
import { BLOCK_STATUS, CookieTableData } from '@ps-analysis-tool/common';
import { CookieTableData } from '@ps-analysis-tool/common';

/**
* Internal dependencies.
Expand Down Expand Up @@ -59,10 +59,7 @@ const BodyRow = ({
const cookieKey = getRowObjectKey(row);
const isBlocked = useIsBlockedToHighlight
? (row.originalData as CookieTableData)?.isBlocked
: (row.originalData as CookieTableData)?.blockingStatus?.inboundBlock !==
BLOCK_STATUS.NOT_BLOCKED ||
(row.originalData as CookieTableData)?.blockingStatus?.outboundBlock !==
BLOCK_STATUS.NOT_BLOCKED;
: Boolean((row.originalData as CookieTableData)?.blockedReasons?.length);
const isHighlighted = (row.originalData as CookieTableData)?.highlighted;
const isDomainInAllowList = (row.originalData as CookieTableData)
?.isDomainInAllowList;
Expand Down

0 comments on commit df69bd5

Please sign in to comment.