Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Cookie Landing page - Part-3 #102

Merged
merged 50 commits into from
Aug 16, 2023
Merged

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Aug 9, 2023

Description

Implement design for cookies landing page and update popup design.

Relevant Technical Choices

  • Add stories for components.
  • Refactor code to reuse developer tools components in the popup.
  • Refactor code.
  • Add dummy data for tests.

Testing Instructions

Additional Information:

Screenshot/Screencast

Landing Page
image

Popup
image


Fixes #66
Fixes #99

@mohdsayed mohdsayed marked this pull request as ready for review August 16, 2023 05:10
@mohdsayed mohdsayed requested a review from mayan-000 August 16, 2023 05:10
@mohdsayed mohdsayed self-assigned this Aug 16, 2023
@mohdsayed mohdsayed added the feature Feature/capability of the tool label Aug 16, 2023
Copy link
Collaborator

@mayan-000 mayan-000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 8c38680 into develop Aug 16, 2023
@mohdsayed mohdsayed deleted the feat/cookies-landing-page-3 branch August 16, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature/capability of the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants