Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "IBC Compliant" status column #105

Merged
merged 1 commit into from
Aug 16, 2023
+0 −179
Merged

Remove "IBC Compliant" status column #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 0 additions & 47 deletions packages/extension/src/utils/checkIbcCompliance.ts
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions packages/extension/src/utils/test-data/cookieMockData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ const data: {
url: 'https://edition.cnn.com/whatever/api',
headerType: 'response',
isFirstParty: true,
isIbcCompliant: true,
isCookieSet: true,
frameIdList: [1],
},
Expand All @@ -93,7 +92,6 @@ const data: {
url: 'https://api.pubmatic.com/whatever/api',
headerType: 'response',
isFirstParty: false,
isIbcCompliant: true,
isCookieSet: true,
frameIdList: [1],
},
Expand All @@ -114,7 +112,6 @@ const data: {
url: 'https://edition.cnn.com/whatever/api',
headerType: 'response',
isFirstParty: true,
isIbcCompliant: true,
isCookieSet: true,
frameIdList: [1],
},
Expand All @@ -135,7 +132,6 @@ const data: {
url: 'https://api.pubmatic.com/whatever/api',
headerType: 'response',
isFirstParty: false,
isIbcCompliant: true,
isCookieSet: true,
frameIdList: [1],
},
Expand All @@ -156,7 +152,6 @@ const data: {
url: 'https://api.pubmatic.com/whatever/api',
headerType: 'response',
isFirstParty: false,
isIbcCompliant: true,
isCookieSet: true,
frameIdList: [1],
},
Expand Down
66 changes: 0 additions & 66 deletions packages/extension/src/utils/tests/checkIbcCompliance.ts
View file
Open in desktop

This file was deleted.

4 changes: 0 additions & 4 deletions packages/extension/src/view/devtools/components/sidebar/tests/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ const mockResponse: {
headerType: 'response',
frameIdList: [1],
isFirstParty: true,
isIbcCompliant: true,
isCookieSet: true,
},
[uncategorized3pCookie.name]: {
Expand All @@ -87,7 +86,6 @@ const mockResponse: {
headerType: 'response',
frameIdList: [1],
isFirstParty: false,
isIbcCompliant: true,
isCookieSet: true,
},
[known1pCookie.name]: {
Expand All @@ -108,7 +106,6 @@ const mockResponse: {
headerType: 'response',
frameIdList: [1],
isFirstParty: true,
isIbcCompliant: true,
isCookieSet: true,
},
[known3pCookie.name]: {
Expand All @@ -129,7 +126,6 @@ const mockResponse: {
headerType: 'response',
frameIdList: [1],
isFirstParty: false,
isIbcCompliant: true,
isCookieSet: true,
},
},
Expand Down
13 changes: 0 additions & 13 deletions ...sion/src/view/devtools/components/tabContent/cookies/cookiesListing/cookieTable/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,19 +137,6 @@ const tableColumns: ColumnDef<CookieTableData>[] = [
</a>
),
},
{
header: 'IBC Compliant',
accessorKey: 'isIbcCompliant',
cell: (info) => (
<p className="flex justify-center items-center">
{info.getValue() ? (
<Check className="scale-125 stroke-onyx dark:stroke-bright-gray" />
) : (
''
)}
</p>
),
},
{
header: 'Cookie Accepted',
accessorKey: 'isCookieSet',
Expand Down
20 changes: 0 additions & 20 deletions ...iew/devtools/components/tabContent/cookies/cookiesListing/cookieTable/stories/tempData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -77,7 +76,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -103,7 +101,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -129,7 +126,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -155,7 +151,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -181,7 +176,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -207,7 +201,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -233,7 +226,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -259,7 +251,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -285,7 +276,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -311,7 +301,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -337,7 +326,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -363,7 +351,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -389,7 +376,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -415,7 +401,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -441,7 +426,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -467,7 +451,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -493,7 +476,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -519,7 +501,6 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
{
parsedCookie: {
Expand All @@ -545,6 +526,5 @@ export const TempCookieData: CookieTableData[] = [
frameIdList: [],
isCookieSet: false,
isFirstParty: true,
isIbcCompliant: false,
},
];
1 change: 0 additions & 1 deletion packages/extension/src/view/devtools/cookies.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
import type { CookieData } from '../../localStore';

export type CookieTableData = CookieData & {
isIbcCompliant: boolean | null;
isCookieSet: boolean | null;
};

Expand Down
Loading