Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to change order of filters. #117

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Add functionality to change order of filters. #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
947c0d2
Add functionality to change order of filters
amovar18 Aug 21, 2023
79527f5
Add missing dot to the text
mohdsayed Aug 21, 2023
0fe7a7b
Merge branch 'develop' of github.com:GoogleChromeLabs/cookie-analysis…
mohdsayed Aug 21, 2023
70f3273
Update filter order
mohdsayed Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...on/src/view/devtools/components/tabContent/cookies/cookiesLanding/cookiesMatrix/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const CookiesMatrix = ({
},
{
title: 'Number of Frames with Associated Cookies',
description: 'Frames that have cookies associated with them',
description: 'Frames that have cookies associated with them.',
count: framesWithCookies ? Object.keys(framesWithCookies).length : 0,
expand: isExpanded,
},
Expand Down
30 changes: 20 additions & 10 deletions packages/extension/src/view/devtools/stateProviders/filterManagementStore/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,39 +20,47 @@ export const FILTER_MAPPING = [
keys: 'analytics.category',
default: 'Uncategorized',
sort: true,
order: 1,
},
{
name: 'Domain',
keys: 'parsedCookie.domain',
sort: true,
order: 3,
},
{
name: 'Platform',
keys: 'analytics.platform',
sort: true,
},
{
name: 'Path',
keys: 'parsedCookie.path',
name: 'HttpOnly',
keys: 'parsedCookie.httponly',
type: 'boolean',
order: 4,
},
{
name: 'Same Site',
keys: 'parsedCookie.samesite',
order: 5,
},
{
name: 'Secure',
keys: 'parsedCookie.secure',
type: 'boolean',
order: 6,
},
{
name: 'HttpOnly',
keys: 'parsedCookie.httponly',
type: 'boolean',
name: 'Path',
keys: 'parsedCookie.path',
order: 7,
},
{
name: 'Platform',
keys: 'analytics.platform',
sort: true,
order: 9,
},
{
name: 'Cookie Accepted',
keys: 'isCookieSet',
type: 'boolean',
order: 10,
},
];

Expand All @@ -61,6 +69,7 @@ export const CUSTOM_FILTER_MAPPING = {
name: 'Scope',
keys: 'isFirstParty',
filters: new Set(['First Party', 'Third Party']),
order: 2,
},
retentionPeriod: {
name: 'Retention Period',
Expand All @@ -72,5 +81,6 @@ export const CUSTOM_FILTER_MAPPING = {
'Long Term (1 week - 1 month)',
'Extended Term (> 1 month)',
]),
order: 8,
},
};
1 change: 1 addition & 0 deletions packages/extension/src/view/devtools/stateProviders/filterManagementStore/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ export interface Filter {
type?: string;
default?: string;
sort?: boolean;
order: number;
}
2 changes: 1 addition & 1 deletion ...ages/extension/src/view/devtools/stateProviders/filterManagementStore/utils/getFilters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const getFilters = (cookies: CookieTableData[]): Filter[] => {

filters.push(...Object.values(CUSTOM_FILTER_MAPPING));

return filters;
return filters.sort((a: Filter, b: Filter) => a.order - b.order);
};

export default getFilters;