Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Cookie table settings should be made persistent #134

Merged
merged 50 commits into from
Oct 4, 2023
Merged

Feature: Cookie table settings should be made persistent #134

merged 50 commits into from
Oct 4, 2023

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Sep 5, 2023 •
edited
Loading

Description

In the application tab, the cookies table settings like column-sizing, column-sorting, frame selected etc. are persistent i.e. they are still applied once the user closes the devtools and then reopens it. We want to apply that same functionality to our tool.

Relevant Technical Choices

  • Storing the tab cookie table settings along with the cookies in the storage.

Testing Instructions

  • Open the terminal and run npm I && npm run dev.
  • Open aljazeera.com and go to the Privacy Sandbox tab.
  • Now open the cookies drop-down and select a frame.
  • Play around in the cookie table and select different sorting methods, toggle columns etc.
  • Close the DevTools.
  • Now reopen the DevTools Navigate to the Privacy Sandbox tab you should see the Tab will be the same way as you left when you closed the DevTools.

Screenshot/Screencast

Screen.Recording.2023-09-05.at.1.58.09.PM.mov

Fixes #74

amovar18 added 30 commits August 22, 2023 12:49
@amovar18
Update package-lock
53b2adf
@amovar18
Move cookieStore to new folder.
6712906
@amovar18
Add preference store.
fb38efd
@amovar18
Update cookieStore references.
e93eb94
@amovar18
Move cookieStore tests to cookieStore folder.
8bb60a1
@amovar18
Add ability to store preferences in the storage.
d9c8025
@amovar18
Update types.
edc7bda
@amovar18
Set persistence of selectedFrame.
00b7451
@amovar18
Make column sorting persistent
48ea605
@amovar18
Make column visibility preference persistent
cb33a5d
@amovar18
Add persistence for selectedFilters
cd67bdf
@amovar18
Conditionally setFilters
6a1517a
@amovar18
Modify preference updating function.
91a54cc 
Update its usage.
Add columnSizing persistence.
@amovar18
Merge branch 'develop' of https://github.com/GoogleChromeLabs/ps-anal…
e56bc13 
…ysis-tool into feat/persistent-settings
@amovar18
Fix selection of the frames.
2662686
@amovar18
Fix sorting problem in react-table.
00d7765
@amovar18
Fix tests.
ce4ecb6
@amovar18
Merge branch 'develop' of https://github.com/GoogleChromeLabs/ps-anal…
e09d745 
…ysis-tool into feat/persistent-settings
@amovar18
Fix accordionState according to set Preference.
3ea9b28
@amovar18
Fix selectedFilters persistence problem.
82f00f4
@amovar18
Merge branch 'develop' of https://github.com/GoogleChromeLabs/ps-anal…
3d1e436 
…ysis-tool into feat/persistent-settings
@amovar18
Merge branch 'develop' of https://github.com/GoogleChromeLabs/ps-anal…
590ce88 
…ysis-tool into feat/persistent-settings
@amovar18
Move SelectedFilters and PreferenceDataValues to common package
208929e
@amovar18
Add column Resizing and column sorting state
565384c
@amovar18
Prettify code
69ab213
@amovar18
Add column visibility.
c91d43a
@amovar18
Prettify and Select accordion
ffa933e
@amovar18
Revert tabFrames condition
e54e4f2
@amovar18
Fix infinite rerender.
19eaf2c
@amovar18
Fix multiple frame filter selection.
5815447
@amovar18 amovar18 marked this pull request as ready for review October 3, 2023 07:22
@amovar18 amovar18 self-assigned this Oct 4, 2023
@amovar18 amovar18 requested review from mohdsayed and amedina October 4, 2023 03:49
@amovar18 amovar18 linked an issue Oct 4, 2023 that may be closed by this pull request
Make cookies table preferences persistent #74
Closed
5 tasks
mohdsayed
mohdsayed approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mohdsayed mohdsayed merged commit e44ca37 into develop Oct 4, 2023
4 checks passed
@mohdsayed mohdsayed deleted the feat/persistent-settings branch October 4, 2023 04:47
@mohdsayed mohdsayed mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

@amedina amedina Awaiting requested review from amedina

Assignees

@amovar18 amovar18

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make cookies table preferences persistent
2 participants
@amovar18 @mohdsayed