Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: List cookies set via document.cookie #146

Merged
merged 19 commits into from
Sep 25, 2023

Conversation

amovar18
Copy link
Collaborator

Description

This PR aims to add cookies that were added via the Javascript method using document.cookie to be displayed in the extension.

Relevant Technical Choices

  • Added a refresh button like the application tab which refreshes the cookies set by the Javascript method.
  • Moved analyse the tab to cover only cookies section other parts such as CHIPS etc are being displayed.
  • Handled the extension context invalidated case by showing a message of context being invalidated.

Testing Instructions

  • Open the terminal and run npm I && npm run dev.
  • Go to travelopia site and open devtools. Go to the application tab and clear all cookies.
  • Now reload the page. Go to the Privacy sandbox tab.
  • There should not be any cookie. Go to the frame under cookies.
  • Click on the refresh button on the side of the search bar.
  • It should load all the cookies that were set using document.cookie method

Screenshot/Screencast


@amovar18 amovar18 changed the title Feat/document cookie list Feature: List cookies set via document.cookie Sep 15, 2023
@amovar18 amovar18 marked this pull request as ready for review September 18, 2023 08:58
@mohdsayed mohdsayed merged commit 073d3c2 into develop Sep 25, 2023
4 checks passed
@mohdsayed mohdsayed deleted the feat/document-cookie-list branch September 25, 2023 20:58
@maitreyie-chavan maitreyie-chavan added the Cookies Issue/feature related to Cookies label Sep 26, 2023
@maitreyie-chavan maitreyie-chavan added this to the v0.3.0 milestone Sep 26, 2023
@mohdsayed mohdsayed mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cookies Issue/feature related to Cookies
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants