Update RWS panel interface #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushnirwal
suggested changes
Sep 22, 2023
The limit has to be implemented by a browser. Chrome has 5 in that sense. As a site owner, one can submit more than 5 associated sites. |
ayushnirwal
approved these changes
Sep 22, 2023
ayushnirwal
reviewed
Sep 22, 2023
| <input | ||
| type="text" | ||
| className={classNames( | ||
| 'my-1 py-1 px-2 outline-none border dark:bg-raisin-black dark:text-bright-gray text-outer-space-crayola', | ||
| 'my-1 py-px px-1 outline-none border border-gainsboro dark:border-quartz dark:bg-raisin-black dark:text-bright-gray text-outer-space-crayola text-xs leading-normal focus:border-bright-navy-blue focus:dark:border-medium-persian-blue', |
There was a problem hiding this comment.
| py-px | padding-top: 1px; padding-bottom: 1px; |
|---|
ayushnirwal
reviewed
Sep 22, 2023
.../extension/src/view/devtools/components/siteBoundaries/relatedWebsiteSets/insights/index.tsx
Show resolved
Hide resolved
mohdsayed
approved these changes
Sep 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes code for making UI/UX touch-ups to the RWS panel, which consists of height, color, font size, line height, scroll into view for form, etc. Alongside includes code to make insights card reactive on tab URL changes.
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Partially addresses #120