Chore: Move presentational components to design system package #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayan-000
force-pushed
the
chore/design-system
branch
from
30cbb82 to
49f902b
Compare
mohdsayed
reviewed
Sep 26, 2023
| const HtmlWebpackPlugin = require('html-webpack-plugin'); | ||
| const CopyPlugin = require('copy-webpack-plugin'); | ||
| const WebpackBar = require('webpackbar'); | ||
| const commonConfig = require('../../webpack.shared.cjs'); |
There was a problem hiding this comment.
👍
This was pending for sometime
mohdsayed
reviewed
Sep 26, 2023
| "cli:dev": "tsc-watch", | ||
| "cli:build": "tsc --build", | ||
| "cli:dev": "npm run dev --workspace=@cookie-analysis-tool/cli", | ||
| "cli:build": "npm run build --workspace=@cookie-analysis-tool/cli", |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves presentational components into its own package named design system. In conjunction to that some config files are made more modular in preparation for cli report package.
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Fixes #