Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic list #159

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Add topic list #159

merged 10 commits into from
Oct 4, 2023

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Oct 2, 2023

Description

Add topics list section to show list of topics using the Topics API

Relevant Technical Choices

Testing Instructions

To test, visit https://topics-demo.glitch.me/ and follow the instructions to enable topics and visit the given URLs.
Then go to chrome://topics-internals/ and click on "Calculate Now".
The topics will only appear in the PS panel if you are able to make it work for https://topics-demo.glitch.me/

Additional Information:

Screenshot/Screencast

image

Fixes #100

@mohdsayed mohdsayed added the feature Feature/capability of the tool label Oct 2, 2023
@mohdsayed mohdsayed self-assigned this Oct 2, 2023
@mohdsayed mohdsayed marked this pull request as ready for review October 4, 2023 02:06
@mohdsayed mohdsayed requested review from mayan-000 and amovar18 and removed request for mayan-000 October 4, 2023 02:56
@amovar18
Copy link
Collaborator

amovar18 commented Oct 4, 2023

Looks good!

@mohdsayed mohdsayed requested a review from amedina October 4, 2023 07:03
@mohdsayed mohdsayed merged commit 43ed029 into develop Oct 4, 2023
4 checks passed
@mohdsayed mohdsayed deleted the feat/add-topics-list branch October 4, 2023 07:03
@mohdsayed mohdsayed mentioned this pull request Oct 11, 2023
@mohdsayed mohdsayed mentioned this pull request Jan 30, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature/capability of the tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants