Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Responsive table on changing dock size. #163

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix: Responsive table on changing dock size. #163

merged 2 commits into from
Oct 4, 2023

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Oct 4, 2023

Description

This PR aims to fix the issue of the table not taking up the whole space when the DecTools dock type is changed.

Relevant Technical Choices

  • Table is forced rerendered once the dock type is changed.

Testing Instructions

Additional Information:

Screenshot/Screencast

Screen.Recording.2023-10-04.at.5.35.20.PM.mov

@mohdsayed mohdsayed requested a review from mayan-000 October 4, 2023 12:15
@mohdsayed mohdsayed marked this pull request as ready for review October 4, 2023 12:16
@mohdsayed mohdsayed added the bug Something isn't working label Oct 4, 2023
mayan-000
mayan-000 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@mayan-000 mayan-000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maitreyie-chavan maitreyie-chavan added this to the v0.3.0 milestone Oct 4, 2023
@mohdsayed mohdsayed requested a review from amedina October 4, 2023 14:26
@mohdsayed mohdsayed merged commit bae0fe5 into develop Oct 4, 2023
@mohdsayed mohdsayed deleted the fix/resize-table branch October 4, 2023 14:26
@mohdsayed mohdsayed mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayan-000 mayan-000 mayan-000 approved these changes

@amedina amedina Awaiting requested review from amedina

Assignees

@amovar18 amovar18

Labels
bug Something isn't working
Projects
PS Analysis Tool
Status: Done
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@amovar18 @mayan-000 @mohdsayed @maitreyie-chavan