Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing page enhancements and fixes #173

Merged
merged 4 commits into from
Oct 8, 2023
Merged

Landing page enhancements and fixes #173

merged 4 commits into from
Oct 8, 2023

Conversation

mohdsayed
Copy link
Collaborator

Description

This PR updates the landing page to encompass some enhancements and fixes some QA issues

Relevant Technical Choices

  • By default, when a page is loaded, the dropdown is in collapsed state. On user toggling, it shows up the content.
  • In case of "CHIPS" or "Topics" or "Attribution", "Bounce Tracking", "Fingerprinting", page is wrapped in LandingPage component to display collapsible content.
  • The InfoCard component is rendered in two variants - one with header (having border, separator in case of "Related Website Sets") and other as plain text (in case it's being rendered in collapsible page for example- CHIPS, Topics etc). So, a prop hasHeader is introduced to differentiate.
  • WIP components has been removed
  • Responsiveness and theme issues highlighted in QA has been addressed

Testing Instructions

Additional Information:

Screenshot/Screencast

Fixes #

@mohdsayed mohdsayed self-assigned this Oct 8, 2023
@mohdsayed mohdsayed requested a review from amovar18 October 8, 2023 14:38
amovar18
amovar18 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 6a2b6ac into develop Oct 8, 2023
4 checks passed
@mohdsayed mohdsayed deleted the feat/landing-page-updates branch October 8, 2023 14:39
@maitreyie-chavan maitreyie-chavan added the enhancement New feature or request label Oct 9, 2023
@maitreyie-chavan maitreyie-chavan added this to the v0.3.0 milestone Oct 9, 2023
@mohdsayed mohdsayed mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amovar18 amovar18 amovar18 approved these changes

Assignees

@mohdsayed mohdsayed

Labels
enhancement New feature or request
Projects
PS Analysis Tool
Status: Done
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mohdsayed @amovar18 @maitreyie-chavan