Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SameSite showing undefined in chips #198

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix: SameSite showing undefined in chips #198

merged 1 commit into from
Oct 23, 2023

Conversation

amovar18
Copy link
Collaborator

Description

This PR aims to introduce a hotfix for the bug where SameSite filter showed undefined in filter chips in cookieTopBar.

Relevant Technical Choices

  • Add sameSite constant to MAPPING_KEYS_TO_NAME.

Testing Instructions

  • Open this branch in a terminal.
  • Run npm start.
  • Open aljazeera.com in Chrome. Open DevTools and go to PrivacySandbox Tab in DevTools.
  • Click on the arrow which is on the left Cookies header.
  • Go to any frame and select filter you should see the filters in a new way FilterName: selectedFilterValue

Additional Information:

Screenshot/Screencast

@amovar18 amovar18 marked this pull request as ready for review October 22, 2023 09:55
@mohdsayed mohdsayed merged commit 5fbb0aa into develop Oct 23, 2023
4 checks passed
@mohdsayed mohdsayed deleted the fix/filter-chips branch October 23, 2023 08:19
@mohdsayed mohdsayed mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

@ayushnirwal ayushnirwal Awaiting requested review from ayushnirwal

@amedina amedina Awaiting requested review from amedina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amovar18 @mohdsayed