Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Report downloader duplicate cookie entries in CSV #200

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

amovar18
Copy link
Collaborator

Description

This PR aims to club all the same name cookies that are in different frames before writing them to the CSV document.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast


@amovar18 amovar18 self-assigned this Oct 23, 2023
@amovar18 amovar18 marked this pull request as ready for review October 23, 2023 13:18
@amovar18 amovar18 requested review from mohdsayed and amedina October 23, 2023 13:18
currentWindow: true,
});
try {
return chrome.tabs.query({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mohdsayed mohdsayed merged commit 2232c79 into develop Oct 23, 2023
4 checks passed
@mohdsayed mohdsayed deleted the fix/report-downloader branch October 23, 2023 13:23
@mohdsayed mohdsayed mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants