Quickly Launch Different Chrome for Privacy Sandbox Demo #211

MiteshShah · 2023-10-24T11:52:02Z

Description

This script helps to launch different Chrome ( Macintosh and Linux platforms) quickly for Privacy Sandbox Demo.

Testing Instructions

curl -sL https://rt.cx/psat | bash

Above command call install.sh which download chrome_launcher.sh and source it into .zshrc or .bashrc also automatically source into the current terminal session as well.

google-cla · 2023-10-24T11:52:07Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

chrome_launcher.sh

mohdsayed · 2023-10-24T12:59:03Z

Instead of downloading the script, shouldn't they be able to run using npm script ? Something like this?

In package.json

"scripts": {
	"launch-chrome:default": "bash ./bin/chrome_launcher/chrome-default.sh",
	"launch-chrome:default-ps": "bash ./bin/chrome_launcher/chrome-default-ps.sh",
	"launch-chrome:3pcd": "bash ./bin/chrome_launcher/chrome-3pcd.sh",
	"launch-chrome:3pcd-ps": "bash ./bin/chrome_launcher/chrome-3pcd-ps.sh",
	"launch-chrome:chip": "bash ./bin/chrome_launcher/chrome-chip.sh"		
}

and then run

npm run launch-chrome:default
npm run launch-chrome:default-ps
npm run launch-chrome:3pcd
...

gagan0123 · 2023-10-24T13:07:16Z

@sayedtaqui

If we go with npm based commands, it will require the users to install git, clone the code, install node, install npm, then install npm dependencies, then they'll be able to run the commands. While going with directly having the script, they only need to run the script once, whether they have git, node or npm installed, it won't matter.

mohdsayed · 2023-10-24T13:22:51Z

@sayedtaqui

If we go with npm based commands, it will require the users to install git, clone the code, install node, install npm, then install npm dependencies, then they'll be able to run the commands. While going with directly having the script, they only need to run the script once, whether they have git, node or npm installed, it won't matter.

Well, we do expect the user to have those for running CLI commands (example npm run cli -- -u https://bbc.com). However, if we are only expecting them to download the file, it doesn't make sense to keep it in the repo because it has no relation to the rest of the codebase. Instead, it can simply be a link to a gist file in the readme. Although, I still think it would be helpful to include the npm command as well.

amedina · 2023-10-24T13:33:57Z

Let's go with the simple command to start and we may add the npm script as well later; although the latter may not be needed.

…

On Tue, Oct 24, 2023, 18:53 Sayed Taqui ***@***.***> wrote: @sayedtaqui <https://github.com/sayedtaqui> If we go with npm based commands, it will require the users to install git, clone the code, install node, install npm, then install npm dependencies, then they'll be able to run the commands. While going with directly having the script, they only need to run the script once, whether they have git, node or npm installed, it won't matter. Well, we do expect the user to have those for running CLI commands (example npm run cli -- -u https://bbc.com). However, if we are only expecting them to download the file, it doesn't make sense to keep it in the repo because it has no relation to the rest of the codebase. Instead, it can simply be a link to a gist file in the readme. Although, I still think it would be helpful to include the npm command as well. — Reply to this email directly, view it on GitHub <#211 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD3R2IQYHUWYAPNHBXUDPTYA66LRAVCNFSM6AAAAAA6NSCXFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZXGE4TMOBSHA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

gagan0123 · 2023-10-25T03:14:26Z

@MiteshShah

/usr/local/bin is owned by the user root so the script won't be able to write data directly. For writing there we'll need to add sudo when downloading the file.

gagan0123 · 2023-10-25T03:16:29Z

Also, can we have a wrapper around to check whether the file exists or not before sourcing it in the .zshrc and .bashrc, something like this:

# Chrome profiles
if [ -f ~/Tools/Scripts/chrome.sh ]; then
    source ~/Tools/Scripts/chrome.sh
fi

MiteshShah · 2023-10-25T05:33:45Z

@gagan0123 I'd modify script so its wont need sudo anymore

To test please clear old source line from .bashrc .zshrc and run following command again

curl -sL https://rt.cx/gpsat | bash

Its will create ~/bin directory and add our chrome_launcher.sh inside it so wont needed sudo
Also now if you check your .bashrc or .zshrc its also check if file exist before source it like you mentioned on above comments.

gagan0123 · 2023-10-25T06:17:50Z

@MiteshShah

The URL https://rt.cx/gpsat is still pointing to the old version of the install script, can we please update this?

mohdsayed · 2023-10-25T06:49:28Z

@MiteshShah Can you please move these files in a new bin folder.

gagan0123 · 2023-10-25T09:12:43Z

@MiteshShah

Thanks, now its loading the correct install script, the redirection was cached in my browser so I was still seeing the old install script.

@sayedtaqui

Can you provide more information where to create a new bin directory and why?

Do you mean in the repo, we should create a bin directory and place these scripts there?

chrome_launcher.sh

mohdsayed · 2023-10-25T09:30:49Z

@gagan0123

Can you provide more information where to create a new bin directory and why?

Do you mean in the repo, we should create a bin directory and place these scripts there?

Yes, please create a bin folder in the root of the repository and move these .sh files into that folder. These .sh files should not be directly dumped in the root folder.

MiteshShah · 2023-10-25T10:30:26Z

@sayedtaqui Moved script to bin folder
@gagan0123 v0.3.1 is updated as well.

gagan0123 · 2023-10-30T16:02:32Z

bin/chrome_launcher.sh

+  extension_setup
+  launch_chrome \
+    --install-autogenerated-theme='150,220,150' \
+    --load-extension="/tmp/ps-analysis-tool-v0.3.0/extension/"


Modify it to get the version from the ps_analysis_tool_version variable that we defined

gagan0123 · 2023-10-30T16:02:39Z

bin/chrome_launcher.sh

+  launch_chrome \
+    --install-autogenerated-theme='255,51,51' \
+    --test-third-party-cookie-phaseout \
+    --load-extension="/tmp/ps-analysis-tool-v0.3.0/extension" \


Modify it to get the version from the ps_analysis_tool_version variable that we defined

gagan0123 · 2023-11-02T05:02:58Z

@MiteshShah

I added two commits for:

Can you please review the code, test it out and improve if needed?

MiteshShah · 2023-11-02T08:19:15Z

@gagan0123 All looks good to me.

mohdsayed · 2023-11-06T12:00:24Z

bin/chrome_launcher.sh

+
+# Download Extension
+extension_setup() {
+  ps_analysis_tool_version=v0.3.1


v0.3.2 just released today

Updating extension version

…ersion-0-3-2 Update extension version onchrome_launcher.sh

gagan0123 · 2023-11-15T07:08:58Z

@MiteshShah

When using MacOS, the directory /private/tmp is utilized to download the extension. However, this directory has a feature that deletes files that have not been used in a while, which results in the deletion of extension files. Even though the directory structure remains in place, all files within it are deleted. Currently, we only verify the existence of the directory, which returns true even when all the extension files have been deleted. Therefore, we need to relocate the unzipped extension to a different temporary location for MacOS. I think /var/tmp will work for our usecase. Do you have any suggestions?

MiteshShah · 2023-11-15T09:43:21Z

@gagan0123 we can use /var/tmp or we can use ~/.psat inside user home directory.
Let me know what you prefer and I'll update the script.

MiteshShah · 2023-11-15T09:44:21Z

@gagan0123 we can use /var/tmp or we can use ~/.psat inside user home directory.
Let me know what you prefer and I'll update the script.

Update PSAT extension version to v0.4.1 for quick launcher CLI

gagan0123 · 2024-01-12T04:52:01Z

@mohdsayed

After the script is installed, we now show a message that you have to either re-source the ~/.bashrc or ~/.zshrc based on the shell the user has, and provide the list of commands as well as shown in the following screenshot:

Do you have any suggestions to improve the output or to make it even clearer to the user, in terms of instructions, what the next steps are after installing the script?

mohdsayed · 2024-01-12T04:59:19Z

@mohdsayed

After the script is installed, we now show a message that you have to either re-source the ~/.bashrc or ~/.zshrc based on the shell the user has, and provide the list of commands as well as shown in the following screenshot:

Do you have any suggestions to improve the output or to make it even clearer to the user, in terms of instructions, what the next steps are after installing the script?

I think we can also add some description to the commands, explaining what they do.

gagan0123 · 2024-01-12T05:52:25Z

@mohdsayed

How about the following?

prasadnevase · 2024-01-15T10:01:03Z

@gagan0123 this looks good to me. Lets merge as it will also address #409

gagan0123 · 2024-01-15T10:54:35Z

I missed the last commit, so added it in this PR: #416

Easily Launch Different Chrome Launcher for Demo

7aa01de

dhsathiya reviewed Oct 24, 2023

View reviewed changes

chrome_launcher.sh Outdated Show resolved Hide resolved

Add Function Comments

ee1f48f

MiteshShah requested a review from dhsathiya October 24, 2023 12:10

Remove unwanted echo

4d26f3d

Installation script

bc418fd

Added script from /usr/local/bin to ~/bin so wont need sudo

08f6357

gagan0123 requested changes Oct 25, 2023

View reviewed changes

chrome_launcher.sh Outdated Show resolved Hide resolved

MiteshShah added 2 commits October 25, 2023 15:51

Update Extenstion Version and Script Location

01c9bd6

Update Installation Script URL for Latest Version

6663ea5

MiteshShah requested a review from gagan0123 October 25, 2023 10:30

gagan0123 approved these changes Oct 25, 2023

View reviewed changes

gagan0123 requested changes Oct 30, 2023

View reviewed changes

amedina assigned MiteshShah Oct 31, 2023

amedina added P0 Highest priority PSAT Features and tasks related to DevTools extension labels Oct 31, 2023

Minor Requested Changes

9765390

mohdsayed reviewed Nov 6, 2023

View reviewed changes

Update chrome_launcher.sh

b578d04

Updating extension version

maitreyie-chavan mentioned this pull request Nov 6, 2023

Update extension version onchrome_launcher.sh #244

Merged

MiteshShah and others added 4 commits November 7, 2023 14:12

Updated Plugin Version

d5bafe6

Windows Scripts

a6c464b

Windows Installation Script

fc8fb9a

Merge pull request #244 from GoogleChromeLabs/updating-extension-to-v…

3c08f3a

…ersion-0-3-2 Update extension version onchrome_launcher.sh

MiteshShah and others added 8 commits November 15, 2023 15:48

Update Extension Path

e4d1037

Remove unwanted stuff

f98b78f

Add --silent-debugger-extension-api

7e62c63

Update tool verion number to the latest

5d82d28

Update PSAT extension version

1772e4a

Merge pull request #389 from GoogleChromeLabs/update-version-to-v0.4.1

6f24dc1

Update PSAT extension version to v0.4.1 for quick launcher CLI

Prevent echoing in terminal when installing

72924f3

Add message after install script executes to help users

24f9303

gagan0123 approved these changes Jan 12, 2024

View reviewed changes

gagan0123 merged commit 6ee6f91 into develop Jan 15, 2024
1 check passed

gagan0123 mentioned this pull request Jan 15, 2024

Enhancement: Add additional documentation with Chrome launcher commands #416

Merged

gagan0123 mentioned this pull request Jan 15, 2024

MacOS Chrome Launcher Script missing .zshrc Handling and Script Sourcing #356

Closed

mohdsayed mentioned this pull request Feb 7, 2024

v0.5.0 #456

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quickly Launch Different Chrome for Privacy Sandbox Demo #211

Quickly Launch Different Chrome for Privacy Sandbox Demo #211

MiteshShah commented Oct 24, 2023 •

edited by gagan0123

Loading

google-cla bot commented Oct 24, 2023

mohdsayed commented Oct 24, 2023

gagan0123 commented Oct 24, 2023

mohdsayed commented Oct 24, 2023

amedina commented Oct 24, 2023 via email

gagan0123 commented Oct 25, 2023

gagan0123 commented Oct 25, 2023

MiteshShah commented Oct 25, 2023

gagan0123 commented Oct 25, 2023

mohdsayed commented Oct 25, 2023

gagan0123 commented Oct 25, 2023

mohdsayed commented Oct 25, 2023

MiteshShah commented Oct 25, 2023

gagan0123 Oct 30, 2023

MiteshShah Oct 31, 2023

gagan0123 Oct 30, 2023

MiteshShah Oct 31, 2023

gagan0123 commented Nov 2, 2023

MiteshShah commented Nov 2, 2023

mohdsayed Nov 6, 2023

MiteshShah Nov 7, 2023

gagan0123 commented Nov 15, 2023

MiteshShah commented Nov 15, 2023

MiteshShah commented Nov 15, 2023

gagan0123 commented Jan 12, 2024

mohdsayed commented Jan 12, 2024

gagan0123 commented Jan 12, 2024

prasadnevase commented Jan 15, 2024

gagan0123 commented Jan 15, 2024

Quickly Launch Different Chrome for Privacy Sandbox Demo #211

Quickly Launch Different Chrome for Privacy Sandbox Demo #211

Conversation

MiteshShah commented Oct 24, 2023 • edited by gagan0123 Loading

Description

Testing Instructions

google-cla bot commented Oct 24, 2023

mohdsayed commented Oct 24, 2023

gagan0123 commented Oct 24, 2023

mohdsayed commented Oct 24, 2023

amedina commented Oct 24, 2023 via email

gagan0123 commented Oct 25, 2023

gagan0123 commented Oct 25, 2023

MiteshShah commented Oct 25, 2023

gagan0123 commented Oct 25, 2023

mohdsayed commented Oct 25, 2023

gagan0123 commented Oct 25, 2023

mohdsayed commented Oct 25, 2023

MiteshShah commented Oct 25, 2023

gagan0123 Oct 30, 2023

Choose a reason for hiding this comment

MiteshShah Oct 31, 2023

Choose a reason for hiding this comment

gagan0123 Oct 30, 2023

Choose a reason for hiding this comment

MiteshShah Oct 31, 2023

Choose a reason for hiding this comment

gagan0123 commented Nov 2, 2023

MiteshShah commented Nov 2, 2023

mohdsayed Nov 6, 2023

Choose a reason for hiding this comment

MiteshShah Nov 7, 2023

Choose a reason for hiding this comment

gagan0123 commented Nov 15, 2023

MiteshShah commented Nov 15, 2023

MiteshShah commented Nov 15, 2023

gagan0123 commented Jan 12, 2024

mohdsayed commented Jan 12, 2024

gagan0123 commented Jan 12, 2024

prasadnevase commented Jan 15, 2024

gagan0123 commented Jan 15, 2024

MiteshShah commented Oct 24, 2023 •

edited by gagan0123

Loading