Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Make functional components in landing page non-collapsible #232

Merged
merged 7 commits into from
Nov 5, 2023

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Nov 4, 2023

Description

This PR implements logic to hide only components serving educational purposes (info card and embed) when clicked on the header title, meanwhile allowing the functional components(eg. RWS generator, topics list) to be non-collapsible.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Screen.Recording.2023-11-04.at.8.38.40.PM.mov

Fixes #209

@mayan-000 mayan-000 marked this pull request as ready for review November 4, 2023 15:15
@mayan-000 mayan-000 requested a review from mohdsayed November 5, 2023 05:59
@mayan-000 mayan-000 self-assigned this Nov 5, 2023
@mohdsayed mohdsayed merged commit 78303a4 into develop Nov 5, 2023
4 checks passed
@mohdsayed mohdsayed deleted the ref/landing-page branch November 5, 2023 12:38
@mohdsayed mohdsayed mentioned this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants