-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Implement generic filtering and search capabilities #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Merged
ayushnirwal
added a commit
that referenced
this pull request
Dec 26, 2023
* Update icons * Setup input textbox and use in cookie top bar * Update clear icon * Update input width * Remove unused component * Update input for light mode * Improve border handling on input focus changes * increase clear icon size * Update icon filename * Add component story * Update fontsize class * Fix: MaxListenerExceedWarning when analyzing sitemap (#260) * Fix:MaxListenersExceededWarning with tech analysis * fix: MaxListenerExceedWarning * Enhancement: add interface use CSV file in CLI. (#274) * enhancement: add interface use CSV file in CLI * refactor: refactor cli routine and spinner behaviour * enhancement:add check for content in CSV file * fixing issue #294 for hovering input field on dark mode (#295) * Enhancement: CLI analyze sites with local sitemap (#271) * enhancement: add interface use CSV file in CLI * refactor: refactor cli routine and spinner behaviour * enhancement:add check for content in CSV file * enhancement:add sitemap parsing * fix:dashboard path * Refactor: Move dashboard's data processing to utils (#192) * Move data processing to utils * Move cookie reshaping to utils * Update icons * Setup input textbox and use in cookie top bar * Move extractCookies into separate file * Update Input -> TextInput * Add test cases * Change function param name * Remoce jest-dom * Change TextInput -> SearchInput * fix:attribute cookie of frame about:blank to unknown frames * Update unknown frame with constant * fix: frame cookies parsing loop * Make frameurl string array for dashboard * Fix test * Update frameUrl to frameUrls --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Fix: Affected cookies csv output (#308) * fix: cookie affected value in downloaded reports * refactor:remove cookie affected column * fix:invalid csv record output * chore: move types to the types file * Feature: Controlling cookie from extension (#278) * Add method to delete cookie from application tab. * Stabalise useContext selector. * Add checkbox component for httponly samesite modification * Modify all properties except expiry * Modfiy checkbox look to match devtools. * Move remove duplicate icons. * Remove unnecessary code diff. * Remove wrong merge files. * Remove unnecessary code diff. * Remove cookies landing. Fix correct import. * Resolve merge issues * Remove empty line commits * Fix bugs * Add function to delete all cookies. * Add delete all cookies method. * Change title. * Add UI/UX changes. * Fix cookie deletion issue. * Fix delete cookie data not being modified. * Refactor useTable to accomodate cli-dashboard and extension * Fix event keydown. * Fix functionality of delete all cookies. * Add exact behaviour as of application tab. * Add hover color * Fix broken UI. * Add hover for clearing all cookies * Fix broken UI and make hover unifrom * Fix hoover white effect. * Fix cookie hover effect. * Handle enter key code. * Cookie modification false value handling. * Cookie modification false value handling. * Add escape key functionality and color red on error. * Fix cookie modification. * Fix tsc error. * Fix cookie modification functionality * Prettify code and refactor some parts to make it look better. * Remove console.log. * Fix cookie modification values and add console log for error * Fix cookie hover issue. * Add the feature to add parity between application tab deletion. * Fix error when toggling visiblity. * Fix focus while modification of cookie. * Make checkbox centered. * Fix error of undefined on null on cookie deletion. * Update badgeText on deleting cookie. * Add colors for hover effect. * By default select next row to be deleted * Disable icon on selecting empty row. * Don not open when console. * Fix cookie deletion method. * Fix dark mode UI. * Disable cookie delete button once frame changes. * Add cookie modification capability for expiry. * Cancel editing once focus is removed. * Disable cookie editing when value changes. * Stop propogation in editable component * Keeping highlighting logic inside Table container * Remove unrequired declaration * Add condition for expiryDate. * Remove border from input field. * Fix failing tests. * Fix cookie filter for strict. * Add proper color for cookie highlight. * Fix session empty values. Fix color of the row. * Fix name not defined. * Fix failing test. * Revert empty name value fix. trim out spaces in value. * Fix minor UI issue. * Fetch JS cookies first. * Disable if cookie key changes. * Add changes to code as suggested. * Change changed key to keyToChange * Prettify data. * Change divRef to inputRef. * Remove unnecessary comment. * Only keep span instead of p tag. * Rename function to be generic and reuse function. * Update getCookieKey function. * Remove unneded changes. * Add suggested feedbacks. * Update variable name. * Update variable name. * Fix flash of old value. * Move dependencies to correct place. * Add early return for code readability. * Add comment to indicate why bruteforce is being done. --------- Co-authored-by: Mayank Rana <mayankranax1@gmail.com> Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Fix: Report generation in cli-dashboard (#318) * refactor:report generation in cli-dashboard * fix: unhandled case for falsy arguments * enhancement: update keys in the report csv file * fix: testing errors * fix: testing errors * code-quality: capitalize constants; use map size to get total cookies * Feature: Add custom sidebar hook and component (#193) * Move data processing to utils * Move cookie reshaping to utils * Add sidebar hook and component * Add sidebar data * Use sidebar component and component * Update import * Move sidebar folder * Select first sidebar item by default * Implement new sidebar in site report component * Move sidebar child out and UI changes * Put FrameUrls into useMemo * Change max width for sidebars and css changes * UI changes * Update icons * Change message box text * Update unknown frame(s) * Update icons * Setup input textbox and use in cookie top bar * Move sidebar to design-system * Move extractCookies into separate file * Update Input -> TextInput * Add test cases * Change function param name * Remoce jest-dom * Change TextInput -> SearchInput * fix:attribute cookie of frame about:blank to unknown frames * Update unknown frame with constant * Export sidebar * Remove style * Pass data to hook --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> Co-authored-by: Ayush Nirwal <53055971+ayushnirwal@users.noreply.github.com> * Feature: Implement keyboard navigation inside sidebar (#266) * Move data processing to utils * Move cookie reshaping to utils * Add sidebar hook and component * Add sidebar data * Use sidebar component and component * Update import * Move sidebar folder * Select first sidebar item by default * Implement new sidebar in site report component * Move sidebar child out and UI changes * Put FrameUrls into useMemo * Change max width for sidebars and css changes * UI changes * Update icons * Change message box text * Update unknown frame(s) * Update icons * Setup input textbox and use in cookie top bar * Move sidebar to design-system * Change sidebar data to obj from arr * Add keyboard navigation and move functions to utils * Don't allow autofocus on intial render * Move extractCookies into separate file * Update Input -> TextInput * Add test cases * Change function param name * Remoce jest-dom * Change TextInput -> SearchInput * fix:attribute cookie of frame about:blank to unknown frames * Update unknown frame with constant * Export sidebar * Refactor util and callback * fix:remove redundent useEffect * fix:remove unintended style change --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Feature: Implement generic filtering and search capabilities (#289) * Move data processing to utils * Move cookie reshaping to utils * Add sidebar hook and component * Add sidebar data * Use sidebar component and component * Update import * Move sidebar folder * Select first sidebar item by default * Implement new sidebar in site report component * Move sidebar child out and UI changes * Put FrameUrls into useMemo * Change max width for sidebars and css changes * UI changes * Update icons * Change message box text * Update unknown frame(s) * Update icons * Setup input textbox and use in cookie top bar * Move sidebar to design-system * Change sidebar data to obj from arr * Add keyboard navigation and move functions to utils * Don't allow autofocus on intial render * Restructure table directory * Add filtering and search hooks in table * Add Chips and filter sidebar and modified props * Add Top bar view * Update folder names * Update condition when no keys provided * Move extractCookies into separate file * Update Input -> TextInput * Add test cases * Change function param name * Remoce jest-dom * Change TextInput -> SearchInput * fix:attribute cookie of frame about:blank to unknown frames * Update unknown frame with constant * Export sidebar * Refactor util and callback * fix:remove unintended style change * fix:add types and other minor changes --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Feature: Integrate filtering and searching capability to cli dashboard (#290) * Move data processing to utils * Move cookie reshaping to utils * Add sidebar hook and component * Add sidebar data * Use sidebar component and component * Update import * Move sidebar folder * Select first sidebar item by default * Implement new sidebar in site report component * Move sidebar child out and UI changes * Put FrameUrls into useMemo * Change max width for sidebars and css changes * UI changes * Update icons * Change message box text * Update unknown frame(s) * Update icons * Setup input textbox and use in cookie top bar * Move sidebar to design-system * Change sidebar data to obj from arr * Add keyboard navigation and move functions to utils * Don't allow autofocus on intial render * Restructure table directory * Add filtering and search hooks in table * Add Chips and filter sidebar and modified props * Add Top bar view * Update folder names * Update condition when no keys provided * Move extractCookies into separate file * Update Input -> TextInput * Add test cases * Add filters for dashboard, update filter logic flow and ui change * Update filters comparator and static values * Update key in filters data * Update search keys for dashboard & minor logic + UI change * Move columns, filerts, searchKeys to cookieListing from tableContainer * Modify affected cookies table to be reusable * Retrieve cookies from store * Add filters and search to affected cookies table * Add filters and search to technology table * Change function param name * Remoce jest-dom * Change TextInput -> SearchInput * Update filter value calculation logic * fix:attribute cookie of frame about:blank to unknown frames * Update unknown frame with constant * Export sidebar * Refactor util and callback * ignore one key --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Feature: Implement persistent settings for table (#291) * Move data processing to utils * Move cookie reshaping to utils * Add sidebar hook and component * Add sidebar data * Use sidebar component and component * Update import * Move sidebar folder * Select first sidebar item by default * Implement new sidebar in site report component * Move sidebar child out and UI changes * Put FrameUrls into useMemo * Change max width for sidebars and css changes * UI changes * Update icons * Change message box text * Update unknown frame(s) * Update icons * Setup input textbox and use in cookie top bar * Move sidebar to design-system * Change sidebar data to obj from arr * Add keyboard navigation and move functions to utils * Don't allow autofocus on intial render * Restructure table directory * Add filtering and search hooks in table * Add Chips and filter sidebar and modified props * Add Top bar view * Update folder names * Update condition when no keys provided * Move extractCookies into separate file * Update Input -> TextInput * Add test cases * Add filters for dashboard, update filter logic flow and ui change * Update filters comparator and static values * Update key in filters data * Update search keys for dashboard & minor logic + UI change * Move columns, filerts, searchKeys to cookieListing from tableContainer * Modify affected cookies table to be reusable * Retrieve cookies from store * Add filters and search to affected cookies table * Add filters and search to technology table * Change function param name * Remoce jest-dom * Change TextInput -> SearchInput * Update filter value calculation logic * fix:attribute cookie of frame about:blank to unknown frames * Update unknown frame with constant * Add function to handle data extraction * Add storage updation mechanism * Handle persistence with custom hook * Handle table settings persistence across all hooks * Export sidebar * Refactor util and callback * Add props for table persistence and disabling filtering * Update frameUrl prop and persistence key creation * Handle size change inside Dispatch callback * Update useTable's internal hooks to set empty values * Update filters persistence logic * Reset filter values on options change * Handle persistence for visibility: * Handle resizing persistence of columns * Change saving visibility data's trigerr * Update resizing logic based on visibility and table changes * Handle sorting persistence * Update filters persistence mechanism * Handle search value on persistence * Update storage utils for saving and extracting persitent settings of table * Update useTable for persistence * Update filter count calculation logic * Handle sorting of filter values * Update persistence keys and props for table * Sort keys and access the object * Use a commonKey for resizing, visbility, sorting * Move to landing page on site change * Use context selector for persistence * Update saving of column sizing mechanism * Flex technology table * Show filter title even when no filter available * Add logic to handle negative width diff * Update selectedSite --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Feature: Implement generic sidebar for extension (#306) * Move data processing to utils * Move cookie reshaping to utils * Add sidebar hook and component * Add sidebar data * Use sidebar component and component * Update import * Move sidebar folder * Select first sidebar item by default * Implement new sidebar in site report component * Move sidebar child out and UI changes * Put FrameUrls into useMemo * Change max width for sidebars and css changes * UI changes * Update icons * Change message box text * Update unknown frame(s) * Update icons * Setup input textbox and use in cookie top bar * Move sidebar to design-system * Change sidebar data to obj from arr * Add keyboard navigation and move functions to utils * Don't allow autofocus on intial render * Restructure table directory * Add filtering and search hooks in table * Add Chips and filter sidebar and modified props * Add Top bar view * Update folder names * Update condition when no keys provided * Move extractCookies into separate file * Update Input -> TextInput * Add test cases * Add filters for dashboard, update filter logic flow and ui change * Update filters comparator and static values * Update key in filters data * Update search keys for dashboard & minor logic + UI change * Move columns, filerts, searchKeys to cookieListing from tableContainer * Modify affected cookies table to be reusable * Retrieve cookies from store * Add filters and search to affected cookies table * Add filters and search to technology table * Change function param name * Remoce jest-dom * Change TextInput -> SearchInput * Update filter value calculation logic * fix:attribute cookie of frame about:blank to unknown frames * Update unknown frame with constant * Add function to handle data extraction * Add storage updation mechanism * Handle persistence with custom hook * Handle table settings persistence across all hooks * Export sidebar * Refactor util and callback * Add props for table persistence and disabling filtering * Update findItem uitl search logic * Update findItem util working * Create sidebarData and use custom sidebar hook & component * Keep auto open and text change * Handle frame selection * Add title to node * Add ux for focus change on clicks * Handle null case for selected frame * Add inspect button inside cookies sidebar item * Handle selectedFrame change from frame overlay * Hide inspect button when tab not analysed * Handle selected sidebar item persistence * Update frameUrl prop and persistence key creation * Handle size change inside Dispatch callback * Update useTable's internal hooks to set empty values * Update filters persistence logic * Reset filter values on options change * Handle persistence for visibility: * Handle resizing persistence of columns * Change saving visibility data's trigerr * Update resizing logic based on visibility and table changes * Handle sorting persistence * Update filters persistence mechanism * Handle search value on persistence * Update storage utils for saving and extracting persitent settings of table * Update useTable for persistence * Update filter count calculation logic * Handle sorting of filter values * Update persistence keys and props for table * Sort keys and access the object * Use a commonKey for resizing, visbility, sorting * Move to landing page on site change * Remove top padding * Remove old sidebar, accordion and old test cases * Use context selector for persistence * Update saving of column sizing mechanism * Add dark mode colors * Flex technology table * Show filter title even when no filter available * Handle change of selectedFrame on redirection * Add logic to handle negative width diff * Handle sidebar item storage and retrieval * Updare use tabID for data extraction * Update left value for extra interface in sidebar title * Decrease left value * Update condition with optional chaining * Make inspect button vertically align * Handle unnecessary re-render * minor refactoring --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Feature: Use Floating UI for tooltip positioning (#276) * Fix tooltip positioning. * Add tooltip to main frame. * Fix unknown and hidden frame tooltip. * Fix arrow overflowing from tooltip. * Fix tooltip for hidden frames and unknown frames when scrolling. * Fix scrollIntoView * Fix angular bottom of tooltip * Handle error messaging. * code-quality:remove JSDoc types * code-quality:add early return and change catch comment * code-quality:replace bind with arrow functions --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Update quick links order and add new item (#329) * Feature: Extract information and show it on settings page for reporting bugs in the extension. (#307) * Add a part for information display in settings page. * change border to underline. * Add copy button and change tab active styling. * Add copy button to the settings page. * Refactor remove useRef and useEffect * Change the heading and add some UI improvements to information page. * style-enhancement:Setting page design changes * fix: tab selector border --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Feature: Add context menu to copy network filter string to filter network requests (#333) * Add the capability to copy network filter string. * Add conditional opening of contextmenu. * Remove isExtension * Fix condition. * style-fix: table body cell context menu --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * reorder column as per new sequence. * Feature: Implements generic filtering and searching capabilities inside the extension (#323) * Move data processing to utils * Move cookie reshaping to utils * Add sidebar hook and component * Add sidebar data * Use sidebar component and component * Update import * Move sidebar folder * Select first sidebar item by default * Implement new sidebar in site report component * Move sidebar child out and UI changes * Put FrameUrls into useMemo * Change max width for sidebars and css changes * UI changes * Update icons * Change message box text * Update unknown frame(s) * Update icons * Setup input textbox and use in cookie top bar * Move sidebar to design-system * Change sidebar data to obj from arr * Add keyboard navigation and move functions to utils * Don't allow autofocus on intial render * Restructure table directory * Add filtering and search hooks in table * Add Chips and filter sidebar and modified props * Add Top bar view * Update folder names * Update condition when no keys provided * Move extractCookies into separate file * Update Input -> TextInput * Add test cases * Add filters for dashboard, update filter logic flow and ui change * Update filters comparator and static values * Update key in filters data * Update search keys for dashboard & minor logic + UI change * Move columns, filerts, searchKeys to cookieListing from tableContainer * Modify affected cookies table to be reusable * Retrieve cookies from store * Add filters and search to affected cookies table * Add filters and search to technology table * Change function param name * Remoce jest-dom * Change TextInput -> SearchInput * Update filter value calculation logic * fix:attribute cookie of frame about:blank to unknown frames * Update unknown frame with constant * Add function to handle data extraction * Add storage updation mechanism * Handle persistence with custom hook * Handle table settings persistence across all hooks * Export sidebar * Refactor util and callback * Add props for table persistence and disabling filtering * Update findItem uitl search logic * Update findItem util working * Create sidebarData and use custom sidebar hook & component * Keep auto open and text change * Handle frame selection * Add title to node * Add ux for focus change on clicks * Handle null case for selected frame * Add inspect button inside cookies sidebar item * Handle selectedFrame change from frame overlay * Hide inspect button when tab not analysed * Handle selected sidebar item persistence * Update frameUrl prop and persistence key creation * Handle size change inside Dispatch callback * Update useTable's internal hooks to set empty values * Update filters persistence logic * Reset filter values on options change * Handle persistence for visibility: * Handle resizing persistence of columns * Change saving visibility data's trigerr * Update resizing logic based on visibility and table changes * Handle sorting persistence * Update filters persistence mechanism * Handle search value on persistence * Update storage utils for saving and extracting persitent settings of table * Update useTable for persistence * Update filter count calculation logic * Handle sorting of filter values * Update persistence keys and props for table * Sort keys and access the object * Use a commonKey for resizing, visbility, sorting * Move to landing page on site change * Remove top padding * Remove old sidebar, accordion and old test cases * Remove old fiters, serach and preference in extension * Pass cookies in frameOverlay * Update testcases * Remove unused type * Create columns, filters and serach for table * Remove filter & preference store related code * Use props for showing extra interface in topbar * Use filter state to extract cookies for frameoverlay * Use context selector for persistence * Update saving of column sizing mechanism * Add dark mode colors * Flex technology table * Show filter title even when no filter available * Handle change of selectedFrame on redirection * Update saving of column sizing mechanism * Add dark mode colors * Flex technology table * Show filter title even when no filter available * Handle change of selectedFrame on redirection * Add table persistent settings provider * Add logic to handle negative width diff * Use utils for frame Filtered cookies * Handle sidebar item storage and retrieval * Updare use tabID for data extraction * Update left value for extra interface in sidebar title * Decrease left value * Update condition with optional chaining * Implement promise queue for persistence * Update sorting condition * Declare pq inside provider * Make inspect button vertically align * Update props for disabling filter button * Update editable components location * change opacity when disabled * Increase margin * Delay the keyboard navigation if key hold * Put portRef in try catch * Remove unrequired setState callback * Move state to custom hook for better manipulation * Update selectedFrame when inspecting stops * post message to content script about inspecting stopped * fix:add p-queue to be transformed when runnig tests * chore:skip tests * style-fix: filter chips style --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Feature: Use Chrome DevTools Protocol to extract extra information (#270) * Add method to attach debugger. * Add baseline CDP support * Add types to the cookie debugger listener. * Fix place for cookiePartitionKey * Show blocked reasons for all cookies. * Show cookie blocked reason for all cookie blocked reason. * Add filtering with priority * Add filter using size. * Fix filter value sorting. * Add a toggle switch to enable usage of CDP * Fix broken tests. * Add cookie exclusion and warning reason. * Use audits to get cookie blocked reasons. * Move common functions to common package. * Fix flickering issue in table. * Handle adding reasons * Add listener for onChange of CDP debugger. * Prettify the reasons. Add samesite lax as default is not specified.. * Add lax as default and use set to deduplicate values of blocked reasons * Fix blocked cookies reasoning in 3pcd environment. * Fix failing test * Remove cookie blocked and blocked reasons column. Add row background color for blocked cookie. * Fix add correct partitionKey Fix undefined blockedReasons. * Handle if no cookie is present in blocked cookie. * Fix cookie dates issue. * Fix date calculation * Add size column * Fix failing tests. * Add cookie blocked and cookie blocked reason in frame overlays. * Fix date parsing. * Fix failing test. * Add cookie warnings. * Preserve cookie warning reason. * Filter cookie correctly. * Merge develop and fix issues. * Revert commit. * Make cookie card scrollable. * Fix cookie partitonKey attribute issue * Fix GRECAPTCHA domain warning reasoning * Fix domain and URL mapper. * Bug fixes for cookie blocked reason. * Fix failing tests. * Fix color of the highlighted item. * Fix cookie blocked editing. * Add handler for error. * Add Blocked cookies header and description in landing page. * Fix error for the request url fetcher. * Fix text color name in tailwind config. * Fix text color name in tailwind config. * Only show those issues which are actually present. * Fix regression change. * Fix key errors. * Fetch cookies from the cdp request. * Fix failing tests. * Fix mockdata add blocked data and legend. * Fix cookie count. * Fix broken UI. * Fix cookie fetcher for document.cookie * Fix column sorting. * Add provision for cli-dashbboard to skip blocked section. * Fix flicker of third-party and first party issue. * Fix count of extension and the popup. * Add description to ExcludeSameSiteUnspecifiedTreatedAsLax * Fix information overlap. * Add spacing between warning reason and blocked reason. * Calculate size of the cookie. * Add cookie reasoning. * Fix formatting of ExcludeSameSiteUnspecifiedTreatedAsLax * Fix expanded view. * Fix failing tests. * Convert cookie blocked to cookie blocked reasons. * Move legend data to constants. * Add modularity for cookies landing section. * Fix color coding in legend. * Fix code structure. * Fix HTML content. * Fix UI responsiveness. * Silence errors. * Add line spacing for blocked reason. * Fix the font sizes. * Fix the font sizes. * Fix cookie coloring. * Fix column sorting and disable and enable cdp switch issue. * Fix failing tests. * Add colors for frames piechart. * Remove bottom border for last 2 elements of matrix. * Add piechat for frames. * Add more readability to service worker. * Remove duplicate color_map declaration. * Rename prepareFrameStateComponent to prepareFrameStatsComponent * Fix samesite lax flicker. * Rename cookie blockages to blocked reasons. * Change CDP toggle switch dimesnions. * Add frame type matrix. * Add line breaks in reasoning. * Fix un-needed changes. * Add padding to message box * Change color in unblocked reason. * Add color to frames. * Fix margin-top and single quote issue. * refactor: address feedback. - remove moment and date-fns. - refactor conditions. - prettify domain and url declaration. * Move cookie issue details into data folder inside common package. * Move prepareCookieStats, prepareFrameStats and prepareCookiesCount to design-system. * Sweep left over references. * Refactor code to remove custom types and use devtools-package. * Change outermost frame to top frame. * Spelling correction. * Refactor: Add theme folder in design-system. Change references for COLOR_MAP. * Simplify prepareFrameStatsComponent. * Refactor: add early return in cookietopbar. * refactor: fix unneeded change in tsconfig.json. * refactor: move condition before update is done. * Change Top Frame to Topmost Frame. * Add early exit and increase code readability. * Fix failing test and convert reason names to colors. * Dont show blocked reason legend when no blocked reason. * Fix errors. * Add overlay fix. * Fix failing test. * Fix merge conflicts. * remove ts lint. * Fix runtime lasterror. --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Reorder columns. * fix: add missing type (#340) * Update type isCookieSet -> isBlocked inside cli dashboard * fix:type and cookie affected value * fix:affected cookies highlighting in cli dashboard * Use extra condition to hide filters sidebar * Always show chips bar * Update filter icon disabling condition * Add condition to change icon on unfocus * Updat test * Add priority and size filters * Add comments * Fix: Regression testing for 0.4 release. (#346) * Update type isCookieSet -> isBlocked inside cli dashboard * fix:type and cookie affected value * fix:affected cookies highlighting in cli dashboard * Use extra condition to hide filters sidebar * Always show chips bar * Update filter icon disabling condition * Add condition to change icon on unfocus * Updat test * Add priority and size filters * Add comments --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Update url colors * fix:update filtering function (#341) * Dont show scrollbar * Dont show scrollbar * Update tailwind config * Update app.css for dashboard with tailwind * Remove blocked reason heading in dashboard * Update sidebar focused condition * Add storage update listener to auto select cookie tab when current tab unanalysed * Fix: Issues generated in regression testing for 0.4 release. (#343) * Fix the frameoverlay icon loading issue. * Fix: disable cookie when no row is selected. * Fix the frameoverlay icon loading issue. * Fix the flow of the debugger. * Fix cookie type. * Fix frame overlay button on initial page load. * fix: rename cookie accepted to cookie affected * Fix: Regression testing for 0.4 release. (#348) * Update type isCookieSet -> isBlocked inside cli dashboard * fix:type and cookie affected value * fix:affected cookies highlighting in cli dashboard * Use extra condition to hide filters sidebar * Always show chips bar * Update filter icon disabling condition * Add condition to change icon on unfocus * Updat test * Add priority and size filters * Add comments * Update url colors * Dont show scrollbar * Dont show scrollbar * Update tailwind config * Update app.css for dashboard with tailwind * Remove blocked reason heading in dashboard * Update sidebar focused condition * Add storage update listener to auto select cookie tab when current tab unanalysed * fix: rename cookie accepted to cookie affected --------- Co-authored-by: ayushnirwal <coding.carrots@gmail.com> * Remove period * Use runtime message listeners for updating tab to listen * Remove old tab data when store data changes * Add try catch to fail silently * Remove size filter * revert: cookie modification and deltion (#347) * Remove reload from popup sync cookie store * Add pq clearing mechanism and cover few callbacks (#353) * Chore: Update version numbers * chore: update changelog * chore: package-lock update * Refactor: Update Chrome and OS info format (#358) * ref: Create platform os enum * ref: Update Chrome and OS info format * Enhancements: CLI interface updates and column reordering (#362) * chore:reorder table coloums in cli dashboard * feat: add flag to omit prompts * feat:add flag to skip technology assesment * feat: Dont show tech table if no data available * fix: Show frames horizontal count component * Revert "feat: Dont show tech table if no data available" This reverts commit 79b3ca7. * feat: Move tech table to bottom and don't show if no data available * feat: add argument to pass no of urls to be analyzed * fix: url limit * fix:ignore creating technologies csv file --------- Co-authored-by: Mayank Rana <mayankranax1@gmail.com> * Fix: Update CDP analysis flow and related UI elements (#357) * Detach debugger from old tabs and only attach to tab being analysed * Uncomment onBeforeNavigate callback * Remove chrome:// protocol * Move debugger attaching before addData function * Fix blocked cookies count and remove promise queue clearing. * Remove making auto entry on tab creation and attaching debugger before navigation * fix:add filter * Remove popup badge text * Revert "Fix blocked cookies count and remove promise queue clearing." This reverts commit 3db0c50. * Don't add data on tab creation * Remove onNavigate event * Add flag for listening to cdp * Detach old tab from debugger * fix: CDP toggling routine * fix: domain calculation with tldts library * fix: popup badge text cleanup * fix: Update event type * Fix blocked cookie count in landing page. * ref: Move blocked reasons and warnings above value * ref: Make fenced frame part of legend * fix: Add space between count and description * Process multitab processing for CDP. Add single tab CDP processing with default analyse of first tab. Reload tabs on switching to unlimited tab processing. Remove toggling of CDP state and remove toggle switch from popup. * Add fenced frames definition. * fix: test cases * fix: Add Invalid domain desc * Fix cookie count in popup. Fix flickering effect in sidebar. * Update details heading color * fix: Update font bold class for description * Make svg fill currentColor and add classes * Fix: Add unknown frames in extension. (#361) * Add unknown frames to the frame url list. * Fix blocked cookies count in frae overlay. * Fix prettier problem and address feedback. * fix: Add conditional check for frameIdsMap assignment * Make the getDomain a function. * Update package-lock.json * Refactor: Update Chrome and OS info format (#358) * ref: Create platform os enum * ref: Update Chrome and OS info format * Enhancements: CLI interface updates and column reordering (#362) * chore:reorder table coloums in cli dashboard * feat: add flag to omit prompts * feat:add flag to skip technology assesment * feat: Dont show tech table if no data available * fix: Show frames horizontal count component * Revert "feat: Dont show tech table if no data available" This reverts commit 79b3ca7. * feat: Move tech table to bottom and don't show if no data available * feat: add argument to pass no of urls to be analyzed * fix: url limit * fix:ignore creating technologies csv file --------- Co-authored-by: Mayank Rana <mayankranax1@gmail.com> * Add comment in file as well. * Move Platform os enum to index * Update enum var name --------- Co-authored-by: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com> Co-authored-by: ayushnirwal <coding.carrots@gmail.com> Co-authored-by: Ayush Nirwal <53055971+ayushnirwal@users.noreply.github.com> * fix:reorder colums in affected cookies table * fix: remove unknown frames from total frame count * chore:update cookie db count * chore:RWS json data * fix: update order in output csv files * fix: update order in output csv files --------- Co-authored-by: Mayank Rana <mayankranax1@gmail.com> Co-authored-by: Mohammad Sayed <6297436+mohdsayed@users.noreply.github.com> Co-authored-by: Fellyph Cintra <fellyph.cintra@gmail.com> Co-authored-by: Mayank Rana <58820001+mayan-000@users.noreply.github.com> Co-authored-by: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements logic and UI for generic filtering and search in the design-system package under the table component, which can be used with Dashboard and Extension.
Relevant Technical Choices
useFiltering
anduseSearch
handles filtering and searching respectively, and are created as a part ofuseTable
hook.useTable
hook with a structure defined inTableFilter
state.useTable
hook.searchKeys
provided inside theuseTable
hook, which loops over entire data and filter out on the basis onsearchValue
.Screenshot/Screencast
Partially addresses #206