Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Update report downloader function to download sitemap report #368

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Feature: Update report downloader function to download sitemap report #368

merged 5 commits into from
Jan 4, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Dec 27, 2023 •
edited by ayushnirwal
Loading

Description

This PR adds functionality to handle the downloading of reports of a sitemap from the sitemap cookie landing page.

The zip file now has a new structure

  • For the sitemap, the zip file will unzip a directory containing directories named after the page URLs which will contain reports for that particular URL.
  • For a single site, the zip file will unzip a directory named after the site given for analysis.

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #262

@mayan-000 mayan-000 self-assigned this Dec 27, 2023
@mayan-000 mayan-000 linked an issue Dec 27, 2023 that may be closed by this pull request
"Download Report" for entire sitemap #262
Closed
ayushnirwal
ayushnirwal suggested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@ayushnirwal ayushnirwal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayan-000 Good work so far, but for a site report a folder inside a folder seems a bit odd.

Ii think we can make 2 utilities generateSiteReportandDownload and generateSiteMapReportandDownload for report generation use cases rather than managing things with an argument.

@mayan-000
Copy link
Collaborator Author

but for a site report a folder inside a folder seems a bit odd.

I guess there's a confusion, I have updated the PR description.

@ayushnirwal

@ayushnirwal ayushnirwal marked this pull request as ready for review January 4, 2024 12:10
@maitreyie-chavan maitreyie-chavan modified the milestone: v0.4.1 Jan 4, 2024
@mohdsayed mohdsayed merged commit 90d3c9e into develop Jan 4, 2024
4 checks passed
@mohdsayed mohdsayed deleted the download-sitemap-report branch January 4, 2024 14:49
fellyph pushed a commit that referenced this pull request Jan 27, 2024
@mayan-000 @fellyph
Feature: Update report downloader function to download sitemap report (…
d4e5b05 
…#368)

* feat: Update report downloader function to download sitemap report

* ref: separate the func for site and sitemap and update functions organisation

* Move folder creation to util and handle last slash removal case

* fix: trim string and use correct condition for hyphen removal

* Update testcases
@mohdsayed mohdsayed mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushnirwal ayushnirwal ayushnirwal approved these changes

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@mayan-000 mayan-000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Download Report" for entire sitemap
4 participants
@mayan-000 @mohdsayed @ayushnirwal @maitreyie-chavan