Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Accept GDPR banner consent. #372

Merged
merged 11 commits into from
Mar 28, 2024
Merged

Feature: Accept GDPR banner consent. #372

merged 11 commits into from
Mar 28, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Dec 29, 2023 •
edited by mohdsayed
Loading

Description

Click on accept all cookies in the GDPR banner button in the CLI.

Relevant Technical Choices

  • In this PR we aim to accept the consent in the GDPR banner provided by OneTrust.

Testing Instructions

  • Clone this branch.
  • In the terminal run npm run cli:build && npm run cli -- --url https://aljazeera.com.
  • In the cli-dashboard under the frame aljazeera.com you will find a cookie OptanonAlertBoxClosed cookie. This signifies the consent box was accepted.

Additional Information:

Screenshot/Screencast

Screenshot 2023-12-29 at 1 43 51 PM

Fixes #204

@amovar18
Feat:
28e6441 
Click on accept all cookies button from the cli.
@amovar18 amovar18 self-assigned this Dec 29, 2023
@mohdsayed mohdsayed added this to the v0.6.0 milestone Jan 19, 2024
@mohdsayed mohdsayed removed this from the v0.6.0 milestone Mar 12, 2024
ayushnirwal
ayushnirwal reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@ayushnirwal ayushnirwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's put the capability of finding the banner behind a flag passed to the CLI. I suggest --accept-banner / -ab.

this.debugLog method can also be used here. It can log if a banner is found or not.

@amovar18 amovar18 marked this pull request as ready for review March 22, 2024 09:26
@ayushnirwal ayushnirwal self-requested a review March 26, 2024 06:23
@mohdsayed mohdsayed merged commit 2db915b into develop Mar 28, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/automate-cli branch March 28, 2024 13:05
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 11, 2024
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushnirwal ayushnirwal ayushnirwal approved these changes

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@amovar18 amovar18

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@amovar18 @mohdsayed @ayushnirwal