Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add unit test for findAnalyticsMatch #438

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Jan 22, 2024

Description

While resolving issue #424 a unit test was added to the utility findAnalyticsMatch testing its capability to match with postfix and prefix wildcard entries in CokieDB. It was realized that it was capable of matching for prefix wildcard entries if they were in CookieDB.
This PR adds the above-mentioned test to the 'develop' branch.

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA). (No QA is needed since only a unit test is needed.)

Fixes #424

@mohdsayed mohdsayed merged commit a91bdd8 into develop Jan 23, 2024
4 checks passed
@mohdsayed mohdsayed deleted the chore/findAnalyticsMatch branch January 23, 2024 06:37
@mohdsayed mohdsayed mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants