Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Column order in output CSV files #443

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Fix: Column order in output CSV files #443

merged 2 commits into from
Jan 24, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Jan 23, 2024 •
edited
Loading

Description

Fixes the order or the CSV record entries in the CLI output files 'cookies.csv' and 'affected-cookies.csv'

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #439

@ayushnirwal ayushnirwal self-assigned this Jan 23, 2024
amovar18
amovar18 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amovar18
Copy link
Collaborator

@ayushnirwal Please resolve conflicts.

@mohdsayed mohdsayed merged commit be02a46 into develop Jan 24, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/csv-output-order branch January 24, 2024 11:36
fellyph pushed a commit that referenced this pull request Jan 27, 2024
@ayushnirwal @fellyph
fix: ordering in CLI output csv files (#443)
4e78aa2
@mohdsayed mohdsayed mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

@amovar18 amovar18 amovar18 approved these changes

Assignees

@ayushnirwal ayushnirwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayushnirwal @amovar18 @mohdsayed