Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miscellaneous allow list QA issues #460

Merged
merged 10 commits into from
Jan 30, 2024
Merged

Fix miscellaneous allow list QA issues #460

merged 10 commits into from
Jan 30, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Jan 30, 2024

Description

  • In the allow list feature, an added allowed domain is stored in chrome.contentSettings for the current browser session. However, this created an issue when the user creates multiple windows while using PSAT, as the content setting gets cleared each time a new chrome window is opened.
  • Fix parent domain issue reported by QA
  • Update context menu text from "Add Domain to Allow List" to "Allow Domain During Session"

Relevant Technical Choices

  • Count number of windows before clearing content to ensure that we do not clear it on new window open.
  • Do not clear content settings on install

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended. (NA)
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Related #376

@mohdsayed mohdsayed self-assigned this Jan 30, 2024
@mohdsayed mohdsayed added the bug Something isn't working label Jan 30, 2024
@mohdsayed mohdsayed requested a review from mayan-000 January 30, 2024 13:40
@mohdsayed mohdsayed changed the title Fix: Prevent clearing content settings when creating a new window. Fix miscellaneous allow list issues Jan 30, 2024
@mohdsayed mohdsayed changed the title Fix miscellaneous allow list issues Fix miscellaneous allow list QA issues Jan 30, 2024
@mohdsayed mohdsayed changed the title Fix miscellaneous allow list QA issues Fix miscellaneous allow list issues Jan 30, 2024
@mohdsayed mohdsayed changed the title Fix miscellaneous allow list issues Fix miscellaneous allow list QA issues Jan 30, 2024
@mohdsayed mohdsayed marked this pull request as ready for review January 30, 2024 13:42
@mohdsayed mohdsayed merged commit de6ac15 into develop Jan 30, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/allowed-list branch January 30, 2024 14:19
@mohdsayed mohdsayed mentioned this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants