Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Fix: Rearrange and rename components in CLI dashboard. #469

Merged
merged 6 commits into from
Feb 6, 2024
Merged

Style Fix: Rearrange and rename components in CLI dashboard. #469

merged 6 commits into from
Feb 6, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Feb 1, 2024 •
edited
Loading

Description

  • Rename "Cookie Classification" to "Cookie Categories".
  • Move the Comparative Insights information under the Blocked Cookies section.

Screenshot/Screencast

Screenshot 2024-02-01 at 1 03 11 PM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@maitreyie-chavan
Copy link
Collaborator

@ayushnirwal

A couple of updates to make here

  1. Instead of Cookies Categories and Comparitive Insights just mention Categories
  2. Add a line breaker between the two sections similar to the extension
  3. Remove the Affected Cookies information

@ayushnirwal ayushnirwal self-assigned this Feb 5, 2024
@ayushnirwal ayushnirwal requested a review from mohdsayed February 5, 2024 05:58
@mohdsayed mohdsayed merged commit 7b96529 into develop Feb 6, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/style-dashboard branch February 6, 2024 09:10
@mohdsayed mohdsayed mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayan-000 mayan-000 mayan-000 approved these changes

@mohdsayed mohdsayed mohdsayed approved these changes

@amovar18 amovar18 Awaiting requested review from amovar18

Assignees

@ayushnirwal ayushnirwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayushnirwal @maitreyie-chavan @mohdsayed @mayan-000