Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move useContextSelector to common package #497

Merged
merged 7 commits into from
Feb 25, 2024
Merged

Refactor: Move useContextSelector to common package #497

merged 7 commits into from
Feb 25, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Feb 15, 2024 •
edited
Loading

Description

This PR moves the overridden useContextSelector from the extension package to common for availability across the repo.
Also updates the equality function for arrays with objects.

Relevant Technical Choices

shallowEqualArrays only works for arrays containing primitive types. So to handle arrays with objects a loop is implemented which uses shallowEqualObjects on individual array item.

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 self-assigned this Feb 15, 2024
@mohdsayed mohdsayed added this to the v0.6.0 milestone Feb 15, 2024
@mayan-000 mayan-000 marked this pull request as ready for review February 16, 2024 08:41
@mayan-000 mayan-000 requested a review from mohdsayed February 16, 2024 08:41
@mayan-000
Squashed commit of the following:
be86aa1 
commit bc7ce7d
Merge: 4e510b2 59622d0
Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com>
Date:   Tue Feb 20 20:19:35 2024 +0530

    Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-tool into develop

commit 4e510b2
Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com>
Date:   Tue Feb 20 20:19:13 2024 +0530

    Fix the reload button staying on the popup.

commit 59622d0
Author: nirwalayush <coding.carrots@gmail.com>
Date:   Tue Feb 20 20:14:51 2024 +0530

    fix: fix details panel showing unknown reason message

commit 809bc38
Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com>
Date:   Tue Feb 20 18:27:30 2024 +0530

    Add <br/> for uniformity.
    Remove top padding from blocking direction.

commit 27242be
Author: Mayank Rana <mayankranax1@gmail.com>
Date:   Tue Feb 20 17:50:11 2024 +0530

    fix: add flags to not highlight rows

commit 3847489
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Tue Feb 20 16:04:36 2024 +0530

    Run audit fix

commit 35af0b4
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Tue Feb 20 16:04:06 2024 +0530

    Bump version

commit 7c74c6a
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Tue Feb 20 16:02:07 2024 +0530

    Update rws data

commit 89378d6
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Tue Feb 20 16:01:45 2024 +0530

    Update cookie database

commit 595f1a7
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Tue Feb 20 16:00:14 2024 +0530

    Update changelog

commit ed0823d
Author: Ayush Nirwal <53055971+ayushnirwal@users.noreply.github.com>
Date:   Tue Feb 20 15:48:21 2024 +0530

    style-fix: scale up prefix icons in table (#514)

commit 0ad08a3
Author: Mohammad Taqui Sayed <6297436+mohdsayed@users.noreply.github.com>
Date:   Tue Feb 20 15:42:20 2024 +0530

    Add UTM params to outgoing links (#512)

    * Add utility function and its test case adding utm params

    * Move util function to common

    * Make util function to handle # URLs and use for latest news and quick links

    * Add UTM links to faciliated testing

    * Update test for dev doc

    * Update link to file issue

    * Remove param from github.com

    * Add utm params to more links

    * Add utm params to all help urls

    * Add utm params to youtube as well

    * Fix tests

commit 9fad900
Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com>
Date:   Tue Feb 20 15:41:44 2024 +0530

    Fix: keep service worker alive (#513)

    * Keep service worker alive once it is profile is started.

    * Add peroidic intervals to send data to devtools and popup for old profile.

    * Remove addition of interval on windows creation.

    * Keep setInverval in the chrome.windows.onCreated.

commit bd1624b
Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com>
Date:   Tue Feb 20 13:23:02 2024 +0530

    Remove relative property. (#511)

    Change messageing for toast message.

commit 7794a22
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Tue Feb 20 10:01:04 2024 +0530

    Chore: Remove logs used for debugging empty cookies

commit 789a40a
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Tue Feb 20 09:58:10 2024 +0530

    Fix popup ui issue

commit dd1b286
Author: Mayank Rana <58820001+mayan-000@users.noreply.github.com>
Date:   Mon Feb 19 20:28:19 2024 +0530

    Enhancement: Update cookie's blocking status enum and UI (#507)

    * ref: add enums for blocking status

    * fix: update deriveBlocking utils

    * feat: add icons and the extractors

    * feat: conditionally render icons

    * test-fix: update deriveBlockingStatus test

    * fix: don't hightlight rows when not using CDP

    * ref: update comment

    * fix: decrease padding

    * fix:manage expiring cookies

    ---------

    Co-authored-by: nirwalayush <coding.carrots@gmail.com>
    Co-authored-by: sayedtaqui <sayedwp@gmail.com>

commit 4fea486
Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com>
Date:   Mon Feb 19 18:20:30 2024 +0530

    Two-step process for toggling CDP state (#494)

    * Add a toast message component in design-system.
    Add mechanism in place to reload all the tabs.
    Add mechanism to show the reload button in the devtools.

    * Add toast message in the popup.

    * Persist toastmessage on reload of extension

    * Add styling to toast message

    * Add a button to match the chrome://flags toast-message.

    * Add a button to the popup.

    * Fix the order of firing of events.

    * Reduce Padding.

    * Reduce vertical padding.

    * Fix the text and add toast message in popup.

    * Add fullstop to the popup messaging.

    * Shorten the devtools message.

    * Remove persistence of the toastMessage

    * use sessionStorage instead of localStorage from web api

    * Fix refresh of the cookies.

    * revert changes.

    * Fix component showing analyse this tab on newtab open.

    * Fix service worker popup connection.

    * Fix the messaging.

    * Fix value being set add new state for display.

    * Fix 0 cookies landing page on multitab debugging issue.

    * Fix padding and the design.

    * Add breakpoints for the button.
    Add breakpoints for text.

    * Fix the fontsize

    * Fix breakpoints

    * Fix text for button.

    * Fix message not showing up in popup.

    * Add comment to listener.
    Add default case to switch block.

    * ref: use absolute to spread toast message

    * Fix the toastmessage while scrolling.

    ---------

    Co-authored-by: Mayank Rana <mayankranax1@gmail.com>

commit f7c4774
Author: Mayank Rana <58820001+mayan-000@users.noreply.github.com>
Date:   Mon Feb 19 17:48:22 2024 +0530

    Refactor: Restructure `Facilitated Testing` landing page UI (#493)

    * add timeline icon

    * ref: restructure UI replicating infocard one

    * ref: update landing page width

    * styles: add breakpoints for bigger screens

    * ref: update the order

commit f7757ad
Author: Mohammad Taqui Sayed <6297436+mohdsayed@users.noreply.github.com>
Date:   Mon Feb 19 17:45:02 2024 +0530

    Fix: Library detection miscellaneous QA issues (#495)

    * Add GIS_EXCEPTIONS and GSIv2_EXCEPTIONS which remove the given feature from UI

    * Review comments address - Developer Testing Pending

    * Add Testcases for filterMatchesBasedOnExceptions

    * Update load delay to 2 sec and show page loading text when page is loading

    * Fix issue where when all signatures are filtered empty state wasnt showing properly

    ---------

    Co-authored-by: Manoj Mohan <jesuismanoj@gmail.com>

commit 84d62ac
Merge: c0ba3b5 88761db
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Fri Feb 16 21:31:14 2024 +0530

    Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-tool into develop

commit c0ba3b5
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Fri Feb 16 21:29:26 2024 +0530

    Add one more log

commit 88761db
Author: Ayush Nirwal <53055971+ayushnirwal@users.noreply.github.com>
Date:   Fri Feb 16 13:26:08 2024 +0530

    Fix: add conditional rendering in technology details panel (#499)

    * feat:add conditional rendering in technology details panel

    * fix: add message for no description available.

commit 1f93d3a
Author: sayedtaqui <sayedwp@gmail.com>
Date:   Thu Feb 15 19:34:41 2024 +0530

    Temp: Add logs for debugging
@mayan-000
Merge branch 'develop' into ref/move-context-selector
3231895
@mayan-000 mayan-000 requested a review from mohdsayed February 23, 2024 08:30
mohdsayed
mohdsayed approved these changes Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the changes.

@mohdsayed mohdsayed merged commit 2eb6715 into develop Feb 25, 2024
4 checks passed
@mohdsayed mohdsayed deleted the ref/move-context-selector branch February 25, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@mayan-000 mayan-000

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mayan-000 @mohdsayed