Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style-Fix: Scale up cookie prefix icon and update message text in cookie details. #514

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Style-Fix: Scale up cookie prefix icon and update message text in cookie details. #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions packages/design-system/src/components/cookieDetails/details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,10 @@ const Details = ({ selectedCookie, isUsingCDP }: DetailsProps) => {
!hasValidBlockedReason &&
isUsingCDP && (
<div className="flex gap-1 items-center mb-4">
<QuestionMark />
<QuestionMark className="scale-150 mr-1" />
<p className="text-outer-space-crayola dark:text-bright-gray">
We could not identify this cookie&apos;s blocking status.
We detected that the cookie was blocked however we could not
detect the reason.
</p>
<br />
</div>
Expand All @@ -133,7 +134,7 @@ const Details = ({ selectedCookie, isUsingCDP }: DetailsProps) => {
hasValidBlockedReason &&
isUsingCDP && (
<div className="flex gap-1 items-center my-4">
<InboundIcon className="stroke-[#FE8455]" />
<InboundIcon className="stroke-[#FE8455] scale-150" />
<p className="text-outer-space-crayola dark:text-bright-gray">
This cookie was blocked in at least one of the responses.
</p>
Expand All @@ -147,7 +148,7 @@ const Details = ({ selectedCookie, isUsingCDP }: DetailsProps) => {
hasValidBlockedReason &&
isUsingCDP && (
<div className="flex gap-1 items-center my-4">
<InboundIcon className="stroke-[#D8302F]" />
<InboundIcon className="stroke-[#D8302F] scale-150" />
<p className="text-outer-space-crayola dark:text-bright-gray">
This cookie was blocked in all responses.
</p>
Expand All @@ -161,7 +162,7 @@ const Details = ({ selectedCookie, isUsingCDP }: DetailsProps) => {
hasValidBlockedReason &&
isUsingCDP && (
<div className="flex gap-1 items-center my-4">
<OutboundIcon className="stroke-[#FE8455]" />
<OutboundIcon className="stroke-[#FE8455] scale-150" />
<p className="text-outer-space-crayola dark:text-bright-gray">
This cookie was blocked in at least one of the requests.
</p>
Expand All @@ -175,7 +176,7 @@ const Details = ({ selectedCookie, isUsingCDP }: DetailsProps) => {
hasValidBlockedReason &&
isUsingCDP && (
<div className="flex gap-1 items-center my-4">
<OutboundIcon className="stroke-[#D8302F]" />
<OutboundIcon className="stroke-[#D8302F] scale-150" />
<p className="text-outer-space-crayola dark:text-bright-gray">
This cookie was blocked in all requests.
</p>
Expand Down
8 changes: 4 additions & 4 deletions ...ew/devtools/components/cookies/cookiesListing/useCookieListing/namePrefixIconSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,16 +78,16 @@ const namePrefixIconSelector = ({ originalData }: TableRow) => {

if (isInboundBlocked) {
if (isInboundBlockedInAll) {
return <InboundIcon className="stroke-[#D8302F]" />;
return <InboundIcon className="stroke-[#D8302F] scale-150" />;
}
return <InboundIcon className="stroke-[#FE8455]" />;
return <InboundIcon className="stroke-[#FE8455] scale-150" />;
}

if (isOutboundBlocked) {
if (isOutboundBlockedInAll) {
return <OutboundIcon className="stroke-[#D8302F]" />;
return <OutboundIcon className="stroke-[#D8302F] scale-150" />;
}
return <OutboundIcon className="stroke-[#FE8455]" />;
return <OutboundIcon className="stroke-[#FE8455] scale-150" />;
}

return <></>;
Expand Down
Loading