Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Extension UI and Service Worker. #519

Merged
merged 49 commits into from
Mar 28, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Feb 22, 2024

Description

This PR aims to improve the developer experience by breaking the code into small pieces and increasing the readability of the code.

Relevant Technical Choices

  • For cookies landing page components are exported from the design-system assembled in the extension and then passed down the landing page as children.
  • The service worker now reuses most of the code to parse headers.
  • The Service worker uses constant for message passing types.

Testing Instructions

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 force-pushed the ref/service-worker-provider branch from c73823d to 84d782f Compare February 22, 2024 12:07
@amovar18 amovar18 self-assigned this Feb 22, 2024
@amovar18 amovar18 marked this pull request as ready for review February 23, 2024 10:20
@amovar18 amovar18 requested review from mohdsayed and mayan-000 and removed request for mohdsayed February 23, 2024 10:20
@amovar18 amovar18 requested a review from mayan-000 March 7, 2024 09:43
@amovar18 amovar18 requested review from mayan-000 and mohdsayed March 8, 2024 15:03
@mohdsayed mohdsayed added this to the v0.7.0 milestone Mar 12, 2024
@ayushnirwal
Copy link
Contributor

@amovar18 please resolve conflicts.

@mohdsayed mohdsayed merged commit a1877df into develop Mar 28, 2024
4 checks passed
@mohdsayed mohdsayed deleted the ref/service-worker-provider branch March 28, 2024 13:07
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants