-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Extension UI and Service Worker. #519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l into ref/service-worker-provider
Refactor files in providers.
- change folder name. - split files to refactor code for appropriate files.
- change folder name. - split files to refactor code for appropriate files.
amovar18
force-pushed
the
ref/service-worker-provider
branch
from
February 22, 2024 12:07
c73823d
to
84d782f
Compare
amovar18
requested review from
mohdsayed and
mayan-000
and removed request for
mohdsayed
February 23, 2024 10:20
mayan-000
reviewed
Mar 5, 2024
.../components/siteReport/tabs/cookies/cookiesLandingContainer/cookieLanding/cookiesSection.tsx
Outdated
Show resolved
Hide resolved
mayan-000
reviewed
Mar 5, 2024
packages/cli-dashboard/src/components/siteReport/tabs/cookies/cookiesLandingContainer/index.tsx
Show resolved
Hide resolved
Add missing component for cli-dashboard cookie landing.
mayan-000
reviewed
Mar 8, 2024
packages/extension/src/view/popup/stateProviders/settings/settingsProvider.tsx
Outdated
Show resolved
Hide resolved
…l into ref/service-worker-provider
@amovar18 please resolve conflicts. |
mohdsayed
approved these changes
Mar 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to improve the developer experience by breaking the code into small pieces and increasing the readability of the code.
Relevant Technical Choices
design-system
assembled in the extension and then passed down the landing page as children.Testing Instructions
Screenshot/Screencast
Checklist