Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show exempted cookies in extension #522

Merged
merged 30 commits into from
Apr 9, 2024
Merged

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Feb 23, 2024

Description

This PR aims to show the cookie exemption reason from the Chrome DevTools Protocol. These are the cookies which were to be blocked but were exempted due to some reasons.

Relevant Technical Choices

Testing Instructions

  • Clone this branch.
  • Go to the terminal and run npm start.
  • Open the browser with 3pcd flags enabled.
  • Load the extension and open edition.cnn.com.
  • Go to PSAT in DevTools and open the cookie table.
  • Allow list a 3rd party cookie and go to the cookies landing page.
  • In the cookies landing page you will see and exempted cookies section with the count and the reasoning.

Additional Information:

Screenshot/Screencast

LandingPage:
Screenshot 2024-02-23 at 15 19 06


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #503

@mohdsayed mohdsayed added this to the v0.7.0 milestone Mar 12, 2024
@amovar18 amovar18 marked this pull request as ready for review April 5, 2024 10:22
@amovar18 amovar18 requested review from mohdsayed and mayan-000 April 9, 2024 06:34
@amovar18 amovar18 requested a review from ayushnirwal April 9, 2024 06:34
@mohdsayed
Copy link
Collaborator

@amovar18 Please resolve conflicts and add some test coverage

@mohdsayed mohdsayed merged commit e20ed93 into develop Apr 9, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/exempted-cookies branch April 9, 2024 14:32
@mohdsayed mohdsayed changed the title Feature: Show Exempted cookies in extension Feature: Show exempted cookies in extension Apr 11, 2024
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants