Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Library detection package to identify more libraries #526

Closed
wants to merge 44 commits into from

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Feb 25, 2024

Description

Refactor the code to identify additional libraries via configuration, and detect the following libraries for known issues.

  • Facebook Like
  • Facebook Comment
  • Disqus Comment
  • Jetpack Comment
  • Jetpack Like
  • reCAPTCHA

Relevant Technical Choices

  • Refactor the library code to increase its generality for detecting other libraries.
  • Verify at least two matches for GSI or GIS and eliminate the override function.
  • Eliminate the exception config as it's no longer necessary.
  • Enhance the code and address outstanding to-do items.

Testing Instructions

  • Test the GIS and GSI library detection on https://www.linkedin.com/ while logged out, as well as on a few more websites. This is due to the code refactoring that the detection logic has undergone.
  • Test all new libraries being added for detection.

Additional Information:

Few websites to test
( QA shouldn't be limited to only these websites )

fb-comments
fb-likes
discus
jetpack Comment
jetpack Like Button
reCAPTCHA

Screenshot/Screencast

image


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #541

@mohdsayed mohdsayed self-assigned this Feb 25, 2024
@mohdsayed mohdsayed changed the title Refactor: Library detection package to detect more libraries Enhancement: Improve the library detection package to identify more libraries Mar 7, 2024
@mohdsayed mohdsayed added this to the v0.6.0 milestone Mar 7, 2024
@mohdsayed mohdsayed added the enhancement New feature or request label Mar 7, 2024
@mohdsayed mohdsayed marked this pull request as ready for review March 7, 2024 18:09
@mohdsayed mohdsayed changed the title Enhancement: Improve the library detection package to identify more libraries Enhancement: Library detection package to identify more libraries Mar 8, 2024
@mohdsayed mohdsayed changed the base branch from develop to release/0.6.0 March 12, 2024 17:19
@mohdsayed mohdsayed changed the base branch from release/0.6.0 to develop March 12, 2024 17:59
@mohdsayed
Copy link
Collaborator Author

Closing in favour of #555

@mohdsayed mohdsayed closed this Mar 12, 2024
@mohdsayed mohdsayed deleted the feat/library-detection-enhancements branch March 12, 2024 18:26
@mohdsayed mohdsayed removed this from the v0.6.0 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant