Refactor: Restructure cookies landing page #528

mayan-000 · 2024-02-26T12:42:32Z

Description

This PR refactors/restructures the cookie's landing page by assembling the cookie landing page independently in the extension and dashboard.

Relevant Technical Choices

Construct the elements of the Cookie landing page inside the extension and dashboard respectively, and after that pass the elements as children to the <CookieLanding /> component.
This allows modularity for assembling the required components as per requirement.

Testing Instructions

Additional Information:

Screenshot/Screencast

Checklist

I have thoroughly tested this code to the best of my abilities.
I have reviewed the code myself before requesting a review.
This code is covered by unit tests to verify that it works as intended.
The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #505

commit bc7ce7d Merge: 4e510b2 59622d0 Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com> Date: Tue Feb 20 20:19:35 2024 +0530 Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-tool into develop commit 4e510b2 Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com> Date: Tue Feb 20 20:19:13 2024 +0530 Fix the reload button staying on the popup. commit 59622d0 Author: nirwalayush <coding.carrots@gmail.com> Date: Tue Feb 20 20:14:51 2024 +0530 fix: fix details panel showing unknown reason message commit 809bc38 Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com> Date: Tue Feb 20 18:27:30 2024 +0530 Add <br/> for uniformity. Remove top padding from blocking direction. commit 27242be Author: Mayank Rana <mayankranax1@gmail.com> Date: Tue Feb 20 17:50:11 2024 +0530 fix: add flags to not highlight rows commit 3847489 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:04:36 2024 +0530 Run audit fix commit 35af0b4 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:04:06 2024 +0530 Bump version commit 7c74c6a Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:02:07 2024 +0530 Update rws data commit 89378d6 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:01:45 2024 +0530 Update cookie database commit 595f1a7 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:00:14 2024 +0530 Update changelog commit ed0823d Author: Ayush Nirwal <53055971+ayushnirwal@users.noreply.github.com> Date: Tue Feb 20 15:48:21 2024 +0530 style-fix: scale up prefix icons in table (#514) commit 0ad08a3 Author: Mohammad Taqui Sayed <6297436+mohdsayed@users.noreply.github.com> Date: Tue Feb 20 15:42:20 2024 +0530 Add UTM params to outgoing links (#512) * Add utility function and its test case adding utm params * Move util function to common * Make util function to handle # URLs and use for latest news and quick links * Add UTM links to faciliated testing * Update test for dev doc * Update link to file issue * Remove param from github.com * Add utm params to more links * Add utm params to all help urls * Add utm params to youtube as well * Fix tests commit 9fad900 Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com> Date: Tue Feb 20 15:41:44 2024 +0530 Fix: keep service worker alive (#513) * Keep service worker alive once it is profile is started. * Add peroidic intervals to send data to devtools and popup for old profile. * Remove addition of interval on windows creation. * Keep setInverval in the chrome.windows.onCreated. commit bd1624b Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com> Date: Tue Feb 20 13:23:02 2024 +0530 Remove relative property. (#511) Change messageing for toast message. commit 7794a22 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 10:01:04 2024 +0530 Chore: Remove logs used for debugging empty cookies commit 789a40a Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 09:58:10 2024 +0530 Fix popup ui issue commit dd1b286 Author: Mayank Rana <58820001+mayan-000@users.noreply.github.com> Date: Mon Feb 19 20:28:19 2024 +0530 Enhancement: Update cookie's blocking status enum and UI (#507) * ref: add enums for blocking status * fix: update deriveBlocking utils * feat: add icons and the extractors * feat: conditionally render icons * test-fix: update deriveBlockingStatus test * fix: don't hightlight rows when not using CDP * ref: update comment * fix: decrease padding * fix:manage expiring cookies --------- Co-authored-by: nirwalayush <coding.carrots@gmail.com> Co-authored-by: sayedtaqui <sayedwp@gmail.com> commit 4fea486 Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com> Date: Mon Feb 19 18:20:30 2024 +0530 Two-step process for toggling CDP state (#494) * Add a toast message component in design-system. Add mechanism in place to reload all the tabs. Add mechanism to show the reload button in the devtools. * Add toast message in the popup. * Persist toastmessage on reload of extension * Add styling to toast message * Add a button to match the chrome://flags toast-message. * Add a button to the popup. * Fix the order of firing of events. * Reduce Padding. * Reduce vertical padding. * Fix the text and add toast message in popup. * Add fullstop to the popup messaging. * Shorten the devtools message. * Remove persistence of the toastMessage * use sessionStorage instead of localStorage from web api * Fix refresh of the cookies. * revert changes. * Fix component showing analyse this tab on newtab open. * Fix service worker popup connection. * Fix the messaging. * Fix value being set add new state for display. * Fix 0 cookies landing page on multitab debugging issue. * Fix padding and the design. * Add breakpoints for the button. Add breakpoints for text. * Fix the fontsize * Fix breakpoints * Fix text for button. * Fix message not showing up in popup. * Add comment to listener. Add default case to switch block. * ref: use absolute to spread toast message * Fix the toastmessage while scrolling. --------- Co-authored-by: Mayank Rana <mayankranax1@gmail.com> commit f7c4774 Author: Mayank Rana <58820001+mayan-000@users.noreply.github.com> Date: Mon Feb 19 17:48:22 2024 +0530 Refactor: Restructure `Facilitated Testing` landing page UI (#493) * add timeline icon * ref: restructure UI replicating infocard one * ref: update landing page width * styles: add breakpoints for bigger screens * ref: update the order commit f7757ad Author: Mohammad Taqui Sayed <6297436+mohdsayed@users.noreply.github.com> Date: Mon Feb 19 17:45:02 2024 +0530 Fix: Library detection miscellaneous QA issues (#495) * Add GIS_EXCEPTIONS and GSIv2_EXCEPTIONS which remove the given feature from UI * Review comments address - Developer Testing Pending * Add Testcases for filterMatchesBasedOnExceptions * Update load delay to 2 sec and show page loading text when page is loading * Fix issue where when all signatures are filtered empty state wasnt showing properly --------- Co-authored-by: Manoj Mohan <jesuismanoj@gmail.com> commit 84d62ac Merge: c0ba3b5 88761db Author: sayedtaqui <sayedwp@gmail.com> Date: Fri Feb 16 21:31:14 2024 +0530 Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-tool into develop commit c0ba3b5 Author: sayedtaqui <sayedwp@gmail.com> Date: Fri Feb 16 21:29:26 2024 +0530 Add one more log commit 88761db Author: Ayush Nirwal <53055971+ayushnirwal@users.noreply.github.com> Date: Fri Feb 16 13:26:08 2024 +0530 Fix: add conditional rendering in technology details panel (#499) * feat:add conditional rendering in technology details panel * fix: add message for no description available. commit 1f93d3a Author: sayedtaqui <sayedwp@gmail.com> Date: Thu Feb 15 19:34:41 2024 +0530 Temp: Add logs for debugging

commit 7b3272e Merge: b9a6f64 2eb6715 Author: Mayank Rana <mayankranax1@gmail.com> Date: Mon Feb 26 15:19:46 2024 +0530 Merge branch 'develop' into ref/provider-to-sidebar commit b9a6f64 Author: Mayank Rana <mayankranax1@gmail.com> Date: Mon Feb 26 15:06:07 2024 +0530 fix: remove component state and use from props commit 8d19cf5 Author: Mayank Rana <mayankranax1@gmail.com> Date: Wed Feb 21 13:40:07 2024 +0530 fix: remove managing of dropdown flag from layout commit 8e925a3 Merge: 0f66f5a 3231895 Author: Mayank Rana <mayankranax1@gmail.com> Date: Wed Feb 21 10:43:25 2024 +0530 Merge branch 'ref/move-context-selector' into ref/provider-to-sidebar commit 3231895 Merge: be86aa1 bc7ce7d Author: Mayank Rana <mayankranax1@gmail.com> Date: Wed Feb 21 10:40:53 2024 +0530 Merge branch 'develop' into ref/move-context-selector commit be86aa1 Author: Mayank Rana <mayankranax1@gmail.com> Date: Wed Feb 21 10:39:01 2024 +0530 Squashed commit of the following: commit bc7ce7d Merge: 4e510b2 59622d0 Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com> Date: Tue Feb 20 20:19:35 2024 +0530 Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-tool into develop commit 4e510b2 Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com> Date: Tue Feb 20 20:19:13 2024 +0530 Fix the reload button staying on the popup. commit 59622d0 Author: nirwalayush <coding.carrots@gmail.com> Date: Tue Feb 20 20:14:51 2024 +0530 fix: fix details panel showing unknown reason message commit 809bc38 Author: Amoghavarsha Kudaligi <kgamoghavarsha@gmail.com> Date: Tue Feb 20 18:27:30 2024 +0530 Add <br/> for uniformity. Remove top padding from blocking direction. commit 27242be Author: Mayank Rana <mayankranax1@gmail.com> Date: Tue Feb 20 17:50:11 2024 +0530 fix: add flags to not highlight rows commit 3847489 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:04:36 2024 +0530 Run audit fix commit 35af0b4 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:04:06 2024 +0530 Bump version commit 7c74c6a Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:02:07 2024 +0530 Update rws data commit 89378d6 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:01:45 2024 +0530 Update cookie database commit 595f1a7 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 16:00:14 2024 +0530 Update changelog commit ed0823d Author: Ayush Nirwal <53055971+ayushnirwal@users.noreply.github.com> Date: Tue Feb 20 15:48:21 2024 +0530 style-fix: scale up prefix icons in table (#514) commit 0ad08a3 Author: Mohammad Taqui Sayed <6297436+mohdsayed@users.noreply.github.com> Date: Tue Feb 20 15:42:20 2024 +0530 Add UTM params to outgoing links (#512) * Add utility function and its test case adding utm params * Move util function to common * Make util function to handle # URLs and use for latest news and quick links * Add UTM links to faciliated testing * Update test for dev doc * Update link to file issue * Remove param from github.com * Add utm params to more links * Add utm params to all help urls * Add utm params to youtube as well * Fix tests commit 9fad900 Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com> Date: Tue Feb 20 15:41:44 2024 +0530 Fix: keep service worker alive (#513) * Keep service worker alive once it is profile is started. * Add peroidic intervals to send data to devtools and popup for old profile. * Remove addition of interval on windows creation. * Keep setInverval in the chrome.windows.onCreated. commit bd1624b Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com> Date: Tue Feb 20 13:23:02 2024 +0530 Remove relative property. (#511) Change messageing for toast message. commit 7794a22 Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 10:01:04 2024 +0530 Chore: Remove logs used for debugging empty cookies commit 789a40a Author: sayedtaqui <sayedwp@gmail.com> Date: Tue Feb 20 09:58:10 2024 +0530 Fix popup ui issue commit dd1b286 Author: Mayank Rana <58820001+mayan-000@users.noreply.github.com> Date: Mon Feb 19 20:28:19 2024 +0530 Enhancement: Update cookie's blocking status enum and UI (#507) * ref: add enums for blocking status * fix: update deriveBlocking utils * feat: add icons and the extractors * feat: conditionally render icons * test-fix: update deriveBlockingStatus test * fix: don't hightlight rows when not using CDP * ref: update comment * fix: decrease padding * fix:manage expiring cookies --------- Co-authored-by: nirwalayush <coding.carrots@gmail.com> Co-authored-by: sayedtaqui <sayedwp@gmail.com> commit 4fea486 Author: Kudaligi Amoghavarsha <kgamoghavarsha@gmail.com> Date: Mon Feb 19 18:20:30 2024 +0530 Two-step process for toggling CDP state (#494) * Add a toast message component in design-system. Add mechanism in place to reload all the tabs. Add mechanism to show the reload button in the devtools. * Add toast message in the popup. * Persist toastmessage on reload of extension * Add styling to toast message * Add a button to match the chrome://flags toast-message. * Add a button to the popup. * Fix the order of firing of events. * Reduce Padding. * Reduce vertical padding. * Fix the text and add toast message in popup. * Add fullstop to the popup messaging. * Shorten the devtools message. * Remove persistence of the toastMessage * use sessionStorage instead of localStorage from web api * Fix refresh of the cookies. * revert changes. * Fix component showing analyse this tab on newtab open. * Fix service worker popup connection. * Fix the messaging. * Fix value being set add new state for display. * Fix 0 cookies landing page on multitab debugging issue. * Fix padding and the design. * Add breakpoints for the button. Add breakpoints for text. * Fix the fontsize * Fix breakpoints * Fix text for button. * Fix message not showing up in popup. * Add comment to listener. Add default case to switch block. * ref: use absolute to spread toast message * Fix the toastmessage while scrolling. --------- Co-authored-by: Mayank Rana <mayankranax1@gmail.com> commit f7c4774 Author: Mayank Rana <58820001+mayan-000@users.noreply.github.com> Date: Mon Feb 19 17:48:22 2024 +0530 Refactor: Restructure `Facilitated Testing` landing page UI (#493) * add timeline icon * ref: restructure UI replicating infocard one * ref: update landing page width * styles: add breakpoints for bigger screens * ref: update the order commit f7757ad Author: Mohammad Taqui Sayed <6297436+mohdsayed@users.noreply.github.com> Date: Mon Feb 19 17:45:02 2024 +0530 Fix: Library detection miscellaneous QA issues (#495) * Add GIS_EXCEPTIONS and GSIv2_EXCEPTIONS which remove the given feature from UI * Review comments address - Developer Testing Pending * Add Testcases for filterMatchesBasedOnExceptions * Update load delay to 2 sec and show page loading text when page is loading * Fix issue where when all signatures are filtered empty state wasnt showing properly --------- Co-authored-by: Manoj Mohan <jesuismanoj@gmail.com> commit 84d62ac Merge: c0ba3b5 88761db Author: sayedtaqui <sayedwp@gmail.com> Date: Fri Feb 16 21:31:14 2024 +0530 Merge branch 'develop' of github.com:GoogleChromeLabs/ps-analysis-tool into develop commit c0ba3b5 Author: sayedtaqui <sayedwp@gmail.com> Date: Fri Feb 16 21:29:26 2024 +0530 Add one more log commit 88761db Author: Ayush Nirwal <53055971+ayushnirwal@users.noreply.github.com> Date: Fri Feb 16 13:26:08 2024 +0530 Fix: add conditional rendering in technology details panel (#499) * feat:add conditional rendering in technology details panel * fix: add message for no description available. commit 1f93d3a Author: sayedtaqui <sayedwp@gmail.com> Date: Thu Feb 15 19:34:41 2024 +0530 Temp: Add logs for debugging commit 0f66f5a Merge: ae88bc7 bc7ce7d Author: Mayank Rana <mayankranax1@gmail.com> Date: Wed Feb 21 08:42:43 2024 +0530 Merge branch 'develop' into ref/provider-to-sidebar commit ae88bc7 Author: Mayank Rana <mayankranax1@gmail.com> Date: Tue Feb 20 13:29:14 2024 +0530 Basic setup of UI commit cf1c60c Merge: 8cad0af 7794a22 Author: Mayank Rana <mayankranax1@gmail.com> Date: Tue Feb 20 13:14:03 2024 +0530 Merge branch 'develop' into ref/provider-to-sidebar commit 8cad0af Author: Mayank Rana <mayankranax1@gmail.com> Date: Tue Feb 20 12:33:54 2024 +0530 feat: add new key for allowing query string for activePanel commit 01f10a3 Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 20:46:06 2024 +0530 use context-selector in siteMapReport component commit fae277c Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 20:37:56 2024 +0530 use context-selector in siteReport component commit d11bb02 Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 20:33:13 2024 +0530 use context-selector inside components commit 0dbcb5d Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 19:33:28 2024 +0530 fix: conditionally update dropdown flag on cookies menu item commit 8e84257 Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 18:29:27 2024 +0530 ref: use callbacks to render UI elements commit 6b3d980 Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 16:38:52 2024 +0530 ref: import useContextSelector from common package commit 080009c Merge: 94927ca 002f331 Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 16:37:32 2024 +0530 Merge branch 'ref/move-context-selector' into ref/provider-to-sidebar commit 94927ca Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 16:37:15 2024 +0530 ref: break UI to new component for using useSidebar hook commit 01301d5 Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 16:36:39 2024 +0530 pef: add provider to useSidebar hook commit 002f331 Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 15:29:41 2024 +0530 ref: import useContextSelector from common package commit aa5167e Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 15:22:32 2024 +0530 perf: improve conditional check for array of objects commit c6874ed Author: Mayank Rana <mayankranax1@gmail.com> Date: Thu Feb 15 14:30:19 2024 +0530 Move useContextSelector to common package

Add missing component for cli-dashboard cookie landing.

Feature: Sticky top-level menu for cookie landing page navigation

mayan-000 and others added 30 commits February 15, 2024 14:30

Move useContextSelector to common package

c6874ed

perf: improve conditional check for array of objects

aa5167e

ref: import useContextSelector from common package

002f331

pef: add provider to useSidebar hook

01301d5

ref: break UI to new component for using useSidebar hook

94927ca

Merge branch 'ref/move-context-selector' into ref/provider-to-sidebar

080009c

ref: import useContextSelector from common package

6b3d980

ref: use callbacks to render UI elements

8e84257

fix: conditionally update dropdown flag on cookies menu item

0dbcb5d

use context-selector inside components

d11bb02

use context-selector in siteReport component

fae277c

use context-selector in siteMapReport component

01f10a3

feat: add new key for allowing query string for activePanel

8cad0af

Merge branch 'develop' into ref/provider-to-sidebar

cf1c60c

Basic setup of UI

ae88bc7

Merge branch 'develop' into ref/provider-to-sidebar

0f66f5a

Merge branch 'develop' into ref/move-context-selector

3231895

Merge branch 'ref/move-context-selector' into ref/provider-to-sidebar

8e925a3

fix: remove managing of dropdown flag from layout

8d19cf5

fix: remove component state and use from props

b9a6f64

Merge branch 'develop' into ref/provider-to-sidebar

7b3272e

Organise cookies section.

c496d0c

ref: rename component

45edb0c

ref: structure cookie landing page on dashboard

a6b2265

ref: create dummy UI for matrix

f065429

ref: update usage of matrix

2b5752e

ref: add expand prop

bba08e8

export componentS

cfc43dc

amovar18 and others added 22 commits March 29, 2024 14:12

Fix cookie tests.

372070e

Fix failing tests.

d846437

Fix import.

f4e0ea9

Fix typo.

d08dd40

Fix condition and make it more readable.

bdcf006

Prettify cookie landing for cli.

1c5400e

Add missing component for cli-dashboard cookie landing.

Fix the problem of inconsistent state of settings in popup and devtools.

732bfd0

Revert settingsChanged setter.

fcb4e31

Make allowedListProvider uniform.

fcd8026

Move type name to constant.

23ae498

Keep only one isValidUrl.

c343ba2

Merge branch 'ref/provider-to-sidebar' into ref/cookies-landing-page

ced8dd5

test: update function and test

6b5a5e3

ref: break sidebar context to separate files

1f5fd60

Merge branch 'ref/provider-to-sidebar' into ref/cookies-landing-page

ae87f90

Move Context Invalidated logic to a custom hook

4c9e9ff

Merge branch 'develop' into ref/provider-to-sidebar

b7fd7ae

Merge branch 'ref/provider-to-sidebar' into ref/cookies-landing-page

3afecdc

Merge branch 'ref/cookies-landing-page' into feat/menu-bar

a0936b0

feat: update code to handle ui change when scrolled

24bae29

implement updated menu bar on landing pages

72960e2

test: update testcases

e15108c

Base automatically changed from ref/provider-to-sidebar to develop April 4, 2024 12:00

mayan-000 and others added 4 commits April 4, 2024 19:16

Merge branch 'develop' into ref/cookies-landing-page

9c653c6

make menu bar stick to right and add background color

47ffd93

Merge pull request #576 from GoogleChromeLabs/feat/menu-bar

e4f9dbe

Feature: Sticky top-level menu for cookie landing page navigation

remove alignment class

6a0c0cd

mohdsayed merged commit d5cec37 into develop Apr 5, 2024
4 checks passed

mohdsayed deleted the ref/cookies-landing-page branch April 5, 2024 03:25

mohdsayed mentioned this pull request Apr 11, 2024

v0.7.0 #607

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor: Restructure cookies landing page #528

Refactor: Restructure cookies landing page #528

mayan-000 commented Feb 26, 2024 •

edited

Loading

Refactor: Restructure cookies landing page #528

Refactor: Restructure cookies landing page #528

Conversation

mayan-000 commented Feb 26, 2024 • edited Loading

Description

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Checklist

mayan-000 commented Feb 26, 2024 •

edited

Loading