Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Update table storage and prefix icon type #546

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Mar 6, 2024

Description

This PR aims to update the type of body-cell's prefix icon to be not wrapped into a function and rendered through a callback. Alongside now uses session storage for table persistence.

Relevant Technical Choices

The icon key will contain Element that will hold the component function which will eventually be rendered inside bodycell as <IconElement />.

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 changed the title Refactor: Update prefix-icon type Refactor: Update table storage and prefix icon type Mar 6, 2024
@mayan-000 mayan-000 self-assigned this Mar 6, 2024
@mayan-000 mayan-000 marked this pull request as ready for review March 7, 2024 08:22
@mayan-000 mayan-000 requested a review from mohdsayed March 7, 2024 08:22
@mohdsayed mohdsayed merged commit 8a59d4e into develop Mar 11, 2024
4 checks passed
@mohdsayed mohdsayed deleted the ref/table-components branch March 11, 2024 08:59
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 11, 2024
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants