Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain selected row’s background color in row selection #548

Closed
wants to merge 1 commit into from

Conversation

mohdsayed
Copy link
Collaborator

Description

As we highlight the selected row in grey background color, it looses its original color during selection. This PR aims to change the selection color for each row.

Relevant Technical Choices

  • Update selection classes

Testing Instructions

Additional Information:

Screenshot/Screencast

selection-color.mp4

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mohdsayed mohdsayed self-assigned this Mar 9, 2024
@mohdsayed mohdsayed added the enhancement New feature or request label Mar 9, 2024
@mohdsayed mohdsayed added this to the v0.6.0 milestone Mar 12, 2024
@mohdsayed mohdsayed changed the base branch from develop to release/0.6.0 March 12, 2024 18:35
@mohdsayed mohdsayed changed the base branch from release/0.6.0 to develop March 12, 2024 18:36
@mohdsayed
Copy link
Collaborator Author

Closing in favour of #556

@mohdsayed mohdsayed closed this Mar 13, 2024
@mohdsayed mohdsayed deleted the fix/row-selection-color branch March 13, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant