Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inconsistency of CDP switch state. #554

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Mar 12, 2024

Description

This PR aims to fix a few issues including inconsistency in the CDP state in the settings page of DevTools and Popup.

Testing Instructions

  • Clone this PR and in the terminal run npm start.
  • Open a fresh Chrome profile and install the PSAT extension.
  • Oen any site and check the state of the CDP switch is inconsistent in the PSAT DevTools page and the PSAT popup.

Screenshot/Screencast

Screenshot 2024-03-12 at 17 20 27

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 self-assigned this Mar 12, 2024
@amovar18 amovar18 marked this pull request as ready for review March 12, 2024 12:36
@amovar18 amovar18 requested a review from mohdsayed March 12, 2024 12:37
@mohdsayed mohdsayed added the bug Something isn't working label Mar 12, 2024
@mohdsayed mohdsayed added this to the v0.6.0 milestone Mar 12, 2024
@mohdsayed mohdsayed changed the base branch from main to release/0.6.0 March 12, 2024 18:28
@mohdsayed mohdsayed merged commit c8cc7df into release/0.6.0 Mar 13, 2024
7 checks passed
@mohdsayed mohdsayed deleted the fix/cdp-inconsistency branch March 13, 2024 06:36
@mohdsayed mohdsayed mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants