Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enable CDP and multi-tab using query parameters #559

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Mar 14, 2024

Description

Enable CDP and multi-tab using query parameters, so that we can enable these settings when using CLI commands

Relevant Technical Choices

Testing Instructions

  • Go to any website like example.com and turn off CDP and mutlitab settings from PSAT settings section.
  • Now go the some website like example.com and use the following query params https://example.com?psat_cdp=on&psat_multitab=on
  • The CDP and multi-tab settings should not be on.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mohdsayed mohdsayed marked this pull request as ready for review March 14, 2024 07:50
@mohdsayed mohdsayed added this to the v0.6.0 milestone Mar 14, 2024
@mohdsayed mohdsayed self-assigned this Mar 14, 2024
@mohdsayed mohdsayed requested a review from amovar18 March 14, 2024 08:00
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 4e538e6 into release/0.6.0 Mar 14, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/enable-cdp-with-query branch March 14, 2024 09:23
@mohdsayed mohdsayed mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants