Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add option to pass a port for development server #579

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Mar 29, 2024

Description

Adds a new argument to the CLI interface '--dashboard-port' or '-po' which can be used to launch the CLI server on a chosen port.

Relevant Technical Choices

  • Naming the new argument CLI interface '--dashboard-port' or '-po'.
  • Add a check that the user has chosen options for the dashboard to be launched before checking for any port conflicts.

Testing Instructions

  • Use the cli command npm run cli -- -u https://edition.cnn.com -po 9009
  • CLI dashboard should be launched on the chosen port.
  • A service running on chosen port should not effect the CLI's functioning if its run in headless mode. npm run cli -- -u https://edition.cnn.com -d ./out

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #573

@ayushnirwal ayushnirwal requested a review from mohdsayed March 29, 2024 06:22
@ayushnirwal ayushnirwal self-assigned this Apr 1, 2024
@mohdsayed mohdsayed merged commit 1747cc7 into develop Apr 2, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/choose-port branch April 2, 2024 19:06
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 2, 2024
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants