Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Rename column cookie affected column to issues #580

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Refactor: Rename column cookie affected column to issues #580

merged 3 commits into from
Apr 2, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Apr 1, 2024 •
edited
Loading

Description

Rename cookie affected column to issues ( short for has issues ) to provide better clarity of the column's meaning.

Testing Instructions

If a cookie table is exported as CSV the column previously titled "Cookie Affected" will be titled "Issues"

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@ayushnirwal ayushnirwal requested a review from mohdsayed April 1, 2024 06:16
@ayushnirwal ayushnirwal self-assigned this Apr 1, 2024
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 2, 2024
@mohdsayed mohdsayed merged commit fb8b64a into develop Apr 2, 2024
4 checks passed
@mohdsayed mohdsayed deleted the ref/rename-column branch April 2, 2024 19:05
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@ayushnirwal ayushnirwal

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushnirwal @mohdsayed