Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Left over references and make some more space in the cookie table. #584

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Apr 3, 2024

Description

This PR aims to hide the priority and size columns since they do not provide any useful information. This PR also aims to sweep some leftover references for unmapped cookies and orphaned cookies from the sidebar.

Testing Instructions

  • Clone this branch. In the terminal run npm start.
  • Open a fresh browser instance and go to https://bbc.com.
  • There should be no Unmapped Cookies or Orphaned Cookies in the frames list.
  • Click on any of the frames having cookies you should see the table without priority and size columns.

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@amovar18 amovar18 self-assigned this Apr 3, 2024
@amovar18 amovar18 marked this pull request as ready for review April 3, 2024 08:04
@amovar18 amovar18 requested a review from mohdsayed April 3, 2024 08:04
@mohdsayed mohdsayed merged commit ca116d8 into develop Apr 3, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/orphaned-unmapped-cookie branch April 3, 2024 13:29
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 11, 2024
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants