Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement : Add blocking status column in the CSV export from the table in extension #591

Merged
merged 11 commits into from
Apr 11, 2024
Merged

Enhancement : Add blocking status column in the CSV export from the table in extension #591

merged 11 commits into from
Apr 11, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Apr 9, 2024 •
edited by mohdsayed
Loading

Description

The added column "Blocking Status" was omitted from the exported CSV in the extension, this PR adds that.

Testing Instructions

  • Enable 3PCD phaseout and CDP mode in the extension for 3p cookies to be blocked.
  • Depending on the cookie's attributes it will be stated as "Blocked" or "Not Blocked" in the exported CSV file.

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@ayushnirwal ayushnirwal self-assigned this Apr 10, 2024
@ayushnirwal ayushnirwal changed the title Enhancement : Add Blocking Status Column In The CSV Export From The Table Enhancement : Add Blocking Status Column In The CSV Export From The Table In Extension Apr 10, 2024
@ayushnirwal ayushnirwal requested a review from mohdsayed April 11, 2024 05:45
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 11, 2024
@mohdsayed mohdsayed changed the title Enhancement : Add Blocking Status Column In The CSV Export From The Table In Extension Enhancement : Add blocking status column in the CSV export from the table in extension Apr 11, 2024
@mohdsayed mohdsayed merged commit 5a0f62e into develop Apr 11, 2024
4 checks passed
@mohdsayed mohdsayed deleted the feat/add-column branch April 11, 2024 07:45
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@ayushnirwal ayushnirwal

Labels
None yet
Projects
PS Analysis Tool
Status: Done
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushnirwal @mohdsayed