Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CLI dashboard showing multiple cookie entries for same cookies #597

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Apr 10, 2024

Description

There were multiple copies of same copies with the only difference being a ".". This PR fixes that issue by adding a "." in front of all the cookie domains missing that. This approach is inspired by how the Chrome browser internally handles cookie domain.

Testing Instructions

  • Analyze the website - https://rtcamp.com.
  • There should not be multiple entries of the same cookie

Screenshot/Screencast

Before

Screenshot 2024-04-10 at 4 12 15 PM

After

Screenshot 2024-04-10 at 4 11 29 PM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@ayushnirwal ayushnirwal self-assigned this Apr 10, 2024
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 11, 2024
@mohdsayed mohdsayed merged commit 44098b6 into develop Apr 11, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/cli-dashboard-multi-select branch April 11, 2024 11:31
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants