Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use warning icon on cookie issues panel #604

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Use warning icon on cookie issues panel #604

merged 1 commit into from
Apr 11, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Apr 11, 2024 •
edited
Loading

Description

This PR adds warning icon to sidebar item named Cookie Issues in CLI dashboard

Relevant Technical Choices

Testing Instructions

  • Run CLI dashboard server.
  • In the sidebar, items with Cookie Issues title will have warning icon.
  • Click on icon, the item should be selected and icon's color should change.
  • Try on both site and sitemap

Additional Information:

Screenshot/Screencast

Screenshot 2024-04-11 at 16 15 23 Screenshot 2024-04-11 at 16 15 38

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 self-assigned this Apr 11, 2024
@mayan-000 mayan-000 added this to the v0.7.0 milestone Apr 11, 2024
@mayan-000 mayan-000 requested a review from mohdsayed April 11, 2024 11:29
@mayan-000 mayan-000 marked this pull request as ready for review April 11, 2024 11:29
@mohdsayed mohdsayed merged commit 1501540 into develop Apr 11, 2024
4 checks passed
@mohdsayed mohdsayed deleted the use-warning-icon branch April 11, 2024 11:31
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@mayan-000 mayan-000

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mayan-000 @mohdsayed