Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Context invalidated for sites which do not send request after site is loaded #611

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Fix: Context invalidated for sites which do not send request after site is loaded #611

merged 4 commits into from
Apr 12, 2024

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Apr 12, 2024 •
edited by mohdsayed
Loading

Description

  • This PR aims to fix the context-invalidated message shown on static sites. These are the sites which once loaded do not send requests to the server which hinders in reading of the cookies.

Relevant Technical Choices

  • This problem only occurs in the multitab environment.
  • When the user opens PSAT in a multitab environment after the extension was updated they will be shown a context-invalidated message.

Testing Instructions

Additional Information:

Screenshot/Screencast

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended. NA
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 12, 2024
@mohdsayed mohdsayed marked this pull request as ready for review April 12, 2024 14:36
mohdsayed
mohdsayed approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@mohdsayed mohdsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thanks

@mohdsayed mohdsayed merged commit b2314a5 into develop Apr 12, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/context-invalidated branch April 12, 2024 14:41
@mohdsayed mohdsayed mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@amovar18 amovar18

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amovar18 @mohdsayed