Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: CLI dashboard blocking reason #618

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Fix: CLI dashboard blocking reason #618

merged 2 commits into from
Apr 15, 2024

Conversation

ayushnirwal
Copy link
Contributor

@ayushnirwal ayushnirwal commented Apr 15, 2024 •
edited
Loading

Description

Details panel was missing blocked reason section. Changing isUsingCDP prop value to true in CLI dashboard fixes it.

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

@ayushnirwal ayushnirwal changed the base branch from main to develop April 15, 2024 05:52
@ayushnirwal ayushnirwal requested a review from mohdsayed April 15, 2024 07:50
@mohdsayed mohdsayed merged commit f218051 into develop Apr 15, 2024
4 checks passed
@mohdsayed mohdsayed deleted the fix/cli-dashboard-blocking-reason branch April 15, 2024 08:09
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 15, 2024
@mohdsayed mohdsayed added the bug Something isn't working label Apr 15, 2024
@mohdsayed mohdsayed mentioned this pull request Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohdsayed mohdsayed mohdsayed approved these changes

Assignees

@ayushnirwal ayushnirwal

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ayushnirwal @mohdsayed